From: Alexey Kodanev <alexey.kodanev@oracle.com>
To: Zeng Linggang <zenglg.jy@cn.fujitsu.com>, ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH v2 2/6] lib6/asapi_04.c: Cleanup
Date: Sat, 06 Jun 2015 16:22:08 +0300 [thread overview]
Message-ID: <5572F400.4050504@oracle.com> (raw)
In-Reply-To: <1433247689-3984-3-git-send-email-zenglg.jy@cn.fujitsu.com>
On 02.06.2015 15:21, Zeng Linggang wrote:
> - for (word = 0; word < 4; ++word)
> - for (bit = 0; bit < 32; ++bit) {
> - uint32_t newbit = 1 << bit;
> + for (word = 0; word < 4; ++word)
> + for (bit = 0; bit < 32; ++bit) {
> + uint32_t newbit = 1 << bit;
1 is int here, please change it to unsigned int as follows:
uint32_t newbit = 1U << bit;
>
> -void *ilistener(void *arg)
> +static void *ilistener(void *arg __attribute__ ((unused)))
LTP has a macro for it, a sort of LTP_ATTR_UNUSED
> -#define MAX(a, b) ((a) >= (b) ? (a) : (b))
> +# define MAX(a, b) ((a) >= (b) ? (a) : (b))
It seems it is not common for LTP coding style to use space there.
> -
> int TST_TOTAL = PTCOUNT + CSCOUNT;
May be move it closer to CSCOUNT?
Best regards,
Alexey
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2015-06-06 13:22 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 7:46 [LTP] [PATCH 1/6] lib6/runcc.c: use TCONF instead of TBROK when no C compiler is present Xing Gu
2015-03-31 7:46 ` [LTP] [PATCH 2/6] lib6/asapi_04.c: cleanup Xing Gu
2015-04-30 11:55 ` Cyril Hrubis
2015-04-30 12:18 ` Cyril Hrubis
2015-03-31 7:46 ` [LTP] [PATCH 3/6] lib6/asapi_05.c: cleanup Xing Gu
2015-04-30 12:15 ` Cyril Hrubis
2015-03-31 7:46 ` [LTP] [PATCH 4/6] lib6/asapi_06.c: cleanup Xing Gu
2015-04-30 13:33 ` Cyril Hrubis
2015-03-31 7:46 ` [LTP] [PATCH 5/6] lib6/getaddrinfo_01.c: cleanup Xing Gu
2015-03-31 7:46 ` [LTP] [PATCH 6/6] ipv6_lib: add it into default Xing Gu
2015-03-31 14:52 ` [LTP] [PATCH 1/6] lib6/runcc.c: use TCONF instead of TBROK when no C compiler is present Alexey Kodanev
2015-04-01 1:38 ` gux.fnst
2015-04-01 7:15 ` Alexey Kodanev
2015-04-14 9:24 ` gux.fnst
2015-04-28 17:24 ` Cyril Hrubis
[not found] ` <1433247689-3984-1-git-send-email-zenglg.jy@cn.fujitsu.com>
[not found] ` <1433247689-3984-2-git-send-email-zenglg.jy@cn.fujitsu.com>
2015-06-06 12:52 ` [LTP] [PATCH v2 1/6] lib6/runcc.c: Cleanup Alexey Kodanev
2015-06-16 12:24 ` [LTP] [PATCH v3 1/7] SAFE_MACROS: Add socket(), bind(), listen(), connect() and getsockname() Zeng Linggang
2015-06-16 12:24 ` [LTP] [PATCH v3 2/7] lib6/runcc.c: Cleanup Zeng Linggang
2015-06-19 16:08 ` Alexey Kodanev
2015-06-16 12:24 ` [LTP] [PATCH v3 3/7] lib6/asapi_04.c: Cleanup Zeng Linggang
2015-06-16 12:24 ` [LTP] [PATCH v3 4/7] lib6/asapi_05.c: Cleanup Zeng Linggang
2015-06-16 12:24 ` [LTP] [PATCH v3 5/7] lib6/asapi_06.c: Cleanup Zeng Linggang
2015-06-16 12:24 ` [LTP] [PATCH v3 6/7] lib6/getaddrinfo_01.c: Cleanup Zeng Linggang
2015-06-16 12:24 ` [LTP] [PATCH v3 7/7] ipv6_lib: Add it into default Zeng Linggang
2015-06-19 14:34 ` [LTP] [PATCH v3 1/7] SAFE_MACROS: Add socket(), bind(), listen(), connect() and getsockname() Alexey Kodanev
2015-07-09 3:05 ` [LTP] [PATCH v4 01/11] " Zeng Linggang
2015-07-09 3:05 ` [LTP] [PATCH v4 02/11] lib6/runcc.c: Cleanup Zeng Linggang
2015-07-09 3:05 ` [LTP] [PATCH v4 03/11] asapi_01: Use 'tst_tmpdir' and more cleanup Zeng Linggang
2015-07-09 3:05 ` [LTP] [PATCH v4 04/11] asapi_02: " Zeng Linggang
2015-07-09 3:05 ` [LTP] [PATCH v4 05/11] asapi_03: " Zeng Linggang
2015-07-09 3:05 ` [LTP] [PATCH v4 06/11] lib6/asapi_04.c: Cleanup Zeng Linggang
2015-07-09 3:05 ` [LTP] [PATCH v4 07/11] lib6/asapi_05.c: Cleanup Zeng Linggang
2015-07-09 3:05 ` [LTP] [PATCH v4 08/11] lib6/asapi_06.c: Cleanup Zeng Linggang
2015-07-09 3:05 ` [LTP] [PATCH v4 09/11] asapi_07: Use 'tst_tmpdir' and more cleanup Zeng Linggang
2015-07-09 3:05 ` [LTP] [PATCH v4 10/11] lib6/getaddrinfo_01.c: Cleanup Zeng Linggang
2015-07-09 3:05 ` [LTP] [PATCH v4 11/11] ipv6_lib: Add it into default Zeng Linggang
2015-07-15 15:49 ` [LTP] [PATCH v4 01/11] SAFE_MACROS: Add socket(), bind(), listen(), connect() and getsockname() Alexey Kodanev
2015-07-16 2:30 ` Zeng Linggang
2015-07-16 5:30 ` [LTP] [PATCH v5 " Zeng Linggang
2015-07-16 5:30 ` [LTP] [PATCH v5 02/11] lib6/runcc.c: Cleanup Zeng Linggang
2015-08-05 17:17 ` Cyril Hrubis
2015-08-05 17:29 ` Cyril Hrubis
[not found] ` <1441016132-18804-1-git-send-email-zenglg.jy@cn.fujitsu.com>
[not found] ` <1441016132-18804-2-git-send-email-zenglg.jy@cn.fujitsu.com>
2015-09-14 9:56 ` [LTP] [PATCH v6 2/7] SAFE_MACROS: Add socket(), bind(), listen(), connect() and getsockname() Alexey Kodanev
2015-07-16 5:30 ` [LTP] [PATCH v5 03/11] asapi_01: Use 'tst_tmpdir' and more cleanup Zeng Linggang
2015-07-16 5:30 ` [LTP] [PATCH v5 04/11] asapi_02: " Zeng Linggang
2015-07-16 5:30 ` [LTP] [PATCH v5 05/11] asapi_03: " Zeng Linggang
2015-07-16 5:30 ` [LTP] [PATCH v5 06/11] lib6/asapi_04.c: Cleanup Zeng Linggang
2015-07-16 5:30 ` [LTP] [PATCH v5 07/11] lib6/asapi_05.c: Cleanup Zeng Linggang
2015-07-16 5:30 ` [LTP] [PATCH v5 08/11] lib6/asapi_06.c: Cleanup Zeng Linggang
2015-07-16 5:30 ` [LTP] [PATCH v5 09/11] asapi_07: Use 'tst_tmpdir' and more cleanup Zeng Linggang
2015-07-16 5:30 ` [LTP] [PATCH v5 10/11] lib6/getaddrinfo_01.c: Cleanup Zeng Linggang
2015-07-16 5:30 ` [LTP] [PATCH v5 11/11] ipv6_lib: Add it into default Zeng Linggang
2015-08-05 14:00 ` [LTP] [PATCH v5 01/11] SAFE_MACROS: Add socket(), bind(), listen(), connect() and getsockname() Cyril Hrubis
[not found] ` <55C236CB.8060508@oracle.com>
[not found] ` <1438858276.11271.20.camel@G08FNSTD140232>
2015-08-06 11:56 ` Cyril Hrubis
[not found] ` <1433247689-3984-3-git-send-email-zenglg.jy@cn.fujitsu.com>
2015-06-06 13:22 ` Alexey Kodanev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5572F400.4050504@oracle.com \
--to=alexey.kodanev@oracle.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=zenglg.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox