[LTP] [PATCH 1/1] kernel:flock/flock01.c: Change tst_resm() followed by tst_exit() to tst_brkm()

[LTP] [PATCH 1/1] kernel:flock/flock01.c: Change tst_resm() followed by tst_exit() to tst_brkm()

[Maninder Singh]

As in commit 9fa8ad0 Change tst_resm() followed by tst_exit() to tst_brkm()

Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
---
 testcases/kernel/syscalls/flock/flock01.c |   12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/testcases/kernel/syscalls/flock/flock01.c b/testcases/kernel/syscalls/flock/flock01.c
index c010608..44b30d1 100644
--- a/testcases/kernel/syscalls/flock/flock01.c
+++ b/testcases/kernel/syscalls/flock/flock01.c
@@ -156,16 +156,8 @@ void setup(void)
 
 	/* creating temporary file */
 	fd = creat(filename, 0644);
-	if (fd < 0) {
-		tst_resm(TFAIL, "creating a new file failed");
-
-		/* Removing temp directory */
-		tst_rmdir();
-
-		/* exit with resturn code appropriate for result */
-		tst_exit();
-
-	}
+	if (fd < 0)
+		tst_brkm(TFAIL, tst_rmdir, "creating a new file failed");
 }
 
 /*
-- 
1.7.9.5
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 1/1] kernel:flock/flock01.c: Change tst_resm() followed by tst_exit() to tst_brkm()

[Stanislav Kholmanskikh]

Hi.

On 06/10/2015 10:58 AM, Maninder Singh wrote:
> As in commit 9fa8ad0 Change tst_resm() followed by tst_exit() to tst_brkm()
>
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
> ---
>   testcases/kernel/syscalls/flock/flock01.c |   12 ++----------
>   1 file changed, 2 insertions(+), 10 deletions(-)
>

You are doing exactly the same thing in two related test cases, so I 
don't see a reason to keep the changes in to separate patches.

Could you, please, merge this patch with the one for flock/flock06.c and 
resend?

Thanks.

------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 1/1] kernel:flock/flock01.c: Change tst_resm() followed by tst_exit() to tst_brkm()

[Maninder Singh]

Hello,

Sure i will send in one patch, I created one patch per file, so that it would be easy for maintainer 
and reviewer to review the changes, and Maintainer can check in same commit both patches.

Thanks and Regards,
Maninder Singh

------- Original Message -------
Sender : Stanislav Kholmanskikh<stanislav.kholmanskikh@oracle.com>
Date : Jun 10, 2015 19:15 (GMT+09:00)
Title : Re: [LTP] [PATCH 1/1] kernel:flock/flock01.c: Change tst_resm() followed by tst_exit() to tst_brkm()

Hi.

On 06/10/2015 10:58 AM, Maninder Singh wrote:
> As in commit 9fa8ad0 Change tst_resm() followed by tst_exit() to tst_brkm()
>
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
> ---
>   testcases/kernel/syscalls/flock/flock01.c |   12 ++----------
>   1 file changed, 2 insertions(+), 10 deletions(-)
>

You are doing exactly the same thing in two related test cases, so I 
don't see a reason to keep the changes in to separate patches.

Could you, please, merge this patch with the one for flock/flock06.c and 
resend?

Thanks.
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list