Re: [LTP] [PATCH] commands/logrotate:run the case once again will failed

[Cui Bixuan <cuibixuan@huawei.com>]

On 2015/7/1 22:10, Alexey Kodanev wrote:
> Hi,
> On 07/01/2015 03:47 PM, Cui Bixuan wrote:
>> ping ~~  :-)
>>
>> On 2015/5/5 20:12, Cui Bixuan wrote:
>>> For the first time,case do 'logrotate -fv tst_logrotate.conf' that will
>>> create the 'half-rotated' file(messages-20150416.gz). When run case again,
>>> the case will fail:
>>> 'error: destination /var/log/messages-20150416.gz already exists,skipping
>>> rotation'
>>>
>>> 'Logrotate' does't expect to find an already existing "half-rotated" file
>>> (http://centos.1050465.n5.nabble.com/CentOS-Logrotate-errors-td5725868.html).
>>> Clean the "half-rotated" file,and the case will pass all the time.
>>>
>>> Signed-off-by: Cui Bixuan<cuibixuan@huawei.com>
>>> ---
>>>   testcases/commands/logrotate/logrotate_tests.sh |    1 +
>>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/testcases/commands/logrotate/logrotate_tests.sh b/testcases/commands/logrotate/logrotate_tests.sh
>>> index 2a793cc..5b14ca0 100755
>>> --- a/testcases/commands/logrotate/logrotate_tests.sh
>>> +++ b/testcases/commands/logrotate/logrotate_tests.sh
>>> @@ -191,6 +191,7 @@ test01()
>>>       do
>>>           rm -f $files > /dev/null 2>&1
>>>       done
>>> +    rm -f /var/log/*`date '+%Y%m%d'`* > /dev/null 2>&1
>>>   
> 
> The test creates only tst_logfile, why it should remove 'messages-*' and other system logs?
> 
> I see that its configuration file includes logrotate.d/, is it really needed by the test?
> 

The tst_logfile of test created is 'messages-*' and the 'messages-*' will cause the case failed,
so we should delete it if we want to the case run succeed at the second time.

And the test creates tst_logfile base on day time. For example, the system time is '2015 Jul 3',
then the case will create 'messages-20150703.gz'. So 'rm -r /var/log/*`date '+%Y%m%d'`*' in patch
only delete the message file of case created (after running it) and not other system logs.

I think, if the logrotate testcase fail when run it the second time,it's a problem of
testcase and we should fix it.

Thanks,
Cui Bixuan

> Thanks,
> Alexey
> 
> 
> 


------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list