[LTP] [PATCH] sched_getattr/sched_getattr01: Use macro definitions to replace numbers

[LTP] [PATCH] sched_getattr/sched_getattr01: Use macro definitions to replace numbers

[Cui Bixuan]

Use 'RUNTIME_VAL','PERIOD_VAL' and 'DEADLINE_VAL' to set attr

Signed-off-by: Cui Bixuan <cuibixuan@huawei.com>
---
 .../syscalls/sched_getattr/sched_getattr01.c       |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/testcases/kernel/syscalls/sched_getattr/sched_getattr01.c b/testcases/kernel/syscalls/sched_getattr/sched_getattr01.c
index 267b8b1..bf6c5b6 100644
--- a/testcases/kernel/syscalls/sched_getattr/sched_getattr01.c
+++ b/testcases/kernel/syscalls/sched_getattr/sched_getattr01.c
@@ -38,9 +38,9 @@ void *run_deadline(void *data LTP_ATTRIBUTE_UNUSED)
 
 	/* This creates a 10ms/30ms reservation */
 	attr.sched_policy = SCHED_DEADLINE;
-	attr.sched_runtime = 10 * 1000 * 1000;
-	attr.sched_period = 30 * 1000 * 1000;
-	attr.sched_deadline = 30 * 1000 * 1000;
+	attr.sched_runtime = RUNTIME_VAL;
+	attr.sched_period = PERIOD_VAL;
+	attr.sched_deadline = DEADLINE_VAL;
 
 	ret = sched_setattr(0, &attr, flags);
 	if (ret < 0)
-- 
1.6.0.2

[LTP] [PATCH] sched_getattr/sched_getattr01: Use macro definitions to replace numbers

[Cyril Hrubis]

Hi!
> Use 'RUNTIME_VAL','PERIOD_VAL' and 'DEADLINE_VAL' to set attr
> 
> Signed-off-by: Cui Bixuan <cuibixuan@huawei.com>
> ---
>  .../syscalls/sched_getattr/sched_getattr01.c       |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/testcases/kernel/syscalls/sched_getattr/sched_getattr01.c b/testcases/kernel/syscalls/sched_getattr/sched_getattr01.c
> index 267b8b1..bf6c5b6 100644
> --- a/testcases/kernel/syscalls/sched_getattr/sched_getattr01.c
> +++ b/testcases/kernel/syscalls/sched_getattr/sched_getattr01.c
> @@ -38,9 +38,9 @@ void *run_deadline(void *data LTP_ATTRIBUTE_UNUSED)
>  
>  	/* This creates a 10ms/30ms reservation */
>  	attr.sched_policy = SCHED_DEADLINE;
> -	attr.sched_runtime = 10 * 1000 * 1000;
> -	attr.sched_period = 30 * 1000 * 1000;
> -	attr.sched_deadline = 30 * 1000 * 1000;
> +	attr.sched_runtime = RUNTIME_VAL;
> +	attr.sched_period = PERIOD_VAL;
> +	attr.sched_deadline = DEADLINE_VAL;

Looking at the test it also misses GPL header in a comment. Can you
please send a patch that adds it as well?
(sorry for not catching that earlier)

-- 
Cyril Hrubis
chrubis@suse.cz

[LTP] [PATCH v2] sched_getattr/sched_getattr01: Use macro definitions to replace numbers

[Cui Bixuan]

Use 'RUNTIME_VAL','PERIOD_VAL' and 'DEADLINE_VAL' to set attr

Signed-off-by: Cui Bixuan <cuibixuan@huawei.com>
---
V2:
    * Add GPL header in testcase;

 .../syscalls/sched_getattr/sched_getattr01.c       |   19 ++++++++++++++++---
 1 files changed, 16 insertions(+), 3 deletions(-)

diff --git a/testcases/kernel/syscalls/sched_getattr/sched_getattr01.c b/testcases/kernel/syscalls/sched_getattr/sched_getattr01.c
index 267b8b1..62faeca 100644
--- a/testcases/kernel/syscalls/sched_getattr/sched_getattr01.c
+++ b/testcases/kernel/syscalls/sched_getattr/sched_getattr01.c
@@ -1,3 +1,16 @@
+/*
+ * Copyright (c) Huawei Technologies Co., Ltd., 2015
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ *  (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
+ * the GNU General Public License for more details.
+ */
+
 #define _GNU_SOURCE
 #include <unistd.h>
 #include <stdio.h>
@@ -38,9 +51,9 @@ void *run_deadline(void *data LTP_ATTRIBUTE_UNUSED)

 	/* This creates a 10ms/30ms reservation */
 	attr.sched_policy = SCHED_DEADLINE;
-	attr.sched_runtime = 10 * 1000 * 1000;
-	attr.sched_period = 30 * 1000 * 1000;
-	attr.sched_deadline = 30 * 1000 * 1000;
+	attr.sched_runtime = RUNTIME_VAL;
+	attr.sched_period = PERIOD_VAL;
+	attr.sched_deadline = DEADLINE_VAL;

 	ret = sched_setattr(0, &attr, flags);
 	if (ret < 0)
-- 
1.6.0.2

[LTP] [PATCH v2] sched_getattr/sched_getattr01: Use macro definitions to replace numbers

[Cyril Hrubis]

Hi!
Pushed, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

[LTP] [PATCH v2] sched_getattr/sched_getattr01: Use macro definitions to replace numbers

[Cui Bixuan]

On 2015/10/27 20:48, Cyril Hrubis wrote:
> Hi!
> Pushed, thanks.
Thanks
>