public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Alexey Kodanev <alexey.kodanev@oracle.com>
To: ltp@lists.linux.it
Subject: [LTP] How about set IPsec with ip xfrm?
Date: Tue, 03 Nov 2015 17:03:05 +0300	[thread overview]
Message-ID: <5638BE99.4010600@oracle.com> (raw)
In-Reply-To: <CAPwn2JS9pB39amE4azR9OP8W18SCC8X=8brxdRLv5swEr5kCLg@mail.gmail.com>

Hi Hangbin,

OK, I've reviewed the icmp tests draft, here are the comments:

* I wouldn't add tst_ipsec() to test_net.sh because this function will 
only be run in IPsec related tests, the rest network tests will include 
it with no good reason. We can move all ipsec related tests to one 
directory under network/stress/ipsec and create common library script there.

* c2x() function can be added to test.sh because it is more or less 
generic, but it should be fixed to print the message in LTP style format.

* Make sure you don't run LTP_RSH directly.

* Don't use absolute path to run commands, it can differ from one 
environment to another. They should be in the PATH before the tests 
start. You can verify that particular command is available with 
tst_check_cmds() in the test script.

* icmp_check_connectivity (ping) can be merged to test_net.sh, other 
network test could run it too.

Thanks,
Alexey


  parent reply	other threads:[~2015-11-03 14:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27  7:32 [LTP] How about set IPsec with ip xfrm? Hangbin Liu
2015-10-27 13:16 ` Alexey Kodanev
2015-10-28  6:52   ` Hangbin Liu
2015-10-28  7:14     ` Alexey Kodanev
2015-11-03 14:03     ` Alexey Kodanev [this message]
2015-11-09  2:42       ` Hangbin Liu
2015-11-09  9:53         ` Alexey Kodanev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5638BE99.4010600@oracle.com \
    --to=alexey.kodanev@oracle.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox