From: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] commands/mkfs: Added new testcase to test mkfs(8) command.
Date: Wed, 4 Nov 2015 13:37:45 +0800 [thread overview]
Message-ID: <563999A9.1090507@cn.fujitsu.com> (raw)
In-Reply-To: <BLU436-SMTP294FE375F1A0F67CEFCDAACF2A0@phx.gbl>
Hi!
>> +mkfs_verify_type()
>> +{
>> + if [ -z "$1" ]; then
>> + blkid $2 | grep -q "ext2"
>> + else
>> + blkid $2 | grep -q "$1"
>> + fi
>> +}
>
> Hi, how about:
> mkfs_verify_type()
> {
> if [ -z "$1" ]; then
> blkid $2 -t TYPE="ext2"
> else
> blkid $2 -t TYPE="$1"
> fi
> }
>
It looks better since it's more logical? thanks!
next prev parent reply other threads:[~2015-11-04 5:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 11:37 [LTP] [PATCH] commands/mkfs: Added new testcase to test mkfs(8) command Guangwen Feng
2015-11-02 15:28 ` Cyril Hrubis
2015-11-03 6:16 ` Guangwen Feng
2015-11-03 11:43 ` [LTP] [PATCH v2] " Guangwen Feng
2015-11-04 4:37 ` =?unknown-8bit?b?5p2O56OK?=
2015-11-04 5:37 ` Guangwen Feng [this message]
2015-11-03 11:20 ` [LTP] [PATCH] " Guangwen Feng
2015-11-03 11:39 ` Cyril Hrubis
2015-11-03 11:55 ` Guangwen Feng
2015-11-04 8:12 ` [LTP] [PATCH v3] " Guangwen Feng
2015-11-04 13:22 ` Cyril Hrubis
2015-11-05 2:03 ` Guangwen Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563999A9.1090507@cn.fujitsu.com \
--to=fenggw-fnst@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox