From: Cedric Hnyda <chnyda@suse.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH V2] controllers/cgroup_fj: fix and clean up
Date: Thu, 5 Nov 2015 16:16:00 +0100 [thread overview]
Message-ID: <563B72B0.7020004@suse.com> (raw)
In-Reply-To: <20151105140242.GC7226@rei>
Hi,
On 11/05/2015 03:02 PM, Cyril Hrubis wrote:
> ...
>> +get_mount_point()
>> +{
>> + check_point=`grep -w $subsystem /proc/mounts | cut -f 2 | cut -d " " -f2`
> I would do even more specific:
>
> grep -w "^$subsystem"
>
> which would match only lines that begin with word "$subsystem".
>
>
> Otherwise this looks good.
>
Thanks for the review.
The format of /proc/mounts is not stable so it might be better to keep
things like they are.
--
Cedric Hnyda
prev parent reply other threads:[~2015-11-05 15:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 9:53 [LTP] [PATCH V2] controllers/cgroup_fj: fix and clean up Cedric Hnyda
2015-11-05 14:02 ` Cyril Hrubis
2015-11-05 15:16 ` Cedric Hnyda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563B72B0.7020004@suse.com \
--to=chnyda@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox