public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Alexey Kodanev <alexey.kodanev@oracle.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH V5] controllers/pids: Add new testcases
Date: Thu, 26 Nov 2015 14:24:40 +0300	[thread overview]
Message-ID: <5656EBF8.3080604@oracle.com> (raw)
In-Reply-To: <1448532423-767-1-git-send-email-chnyda@suse.com>

Hi,
On 11/26/2015 01:07 PM, Cedric Hnyda wrote:
> Created new testcases to test the pids controller
> which is used to stop any new tasks from being fork()'d
> after a certain limit is reached.
>
>
> +
> +usage()
> +{
> +	echo "usage: ./pids01 caseno max"
> +	tst_resm TFAIL "invalid parameters"

The messages could be merged into one, no need to print two:

tst_resm TFAIL "invalid parameters, usage: ..."

> +
> +start_pids_tasks2()
> +{
> +	nb=$1
> +	for i in `seq 1 $nb`; do
> +		pids_task2 &
> +		echo $! > $testpath/tasks
> +	done
> +
> +	if [ $(cat "$testpath/tasks" | wc -l) -ne $nb ]; then
> +		tst_resm TBROK "..."

Please make it more informative :)

Thanks,
Alexey

      reply	other threads:[~2015-11-26 11:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-26 10:07 [LTP] [PATCH V5] controllers/pids: Add new testcases Cedric Hnyda
2015-11-26 11:24 ` Alexey Kodanev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5656EBF8.3080604@oracle.com \
    --to=alexey.kodanev@oracle.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox