From: Alexey Kodanev <alexey.kodanev@oracle.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3] hugetlb: add new testcase hugeshmat05.c
Date: Fri, 25 Dec 2015 12:09:59 +0300 [thread overview]
Message-ID: <567D07E7.7040601@oracle.com> (raw)
In-Reply-To: <1450696717-6983-1-git-send-email-liwang@redhat.com>
Hi,
On 12/21/2015 02:18 PM, Li Wang wrote:
> shmget()/shmat() fails to allocate huge pages shared memory segment
> with EINVAL if its size is not in the range [ N*HUGE_PAGE_SIZE - 4095,
> N*HUGE_PAGE_SIZE ]. This is a problem in the memory segment size round
> up algorithm. The requested size is rounded up to PAGE_SIZE (4096), but
> if this roundup does not match HUGE_PAGE_SIZE (2Mb) boundary - the
> allocation fails.
Applied, thanks!
Also fixed some style warns and errors:
ERROR: need consistent spacing around '-' (ctx:WxV)
#177: FILE: testcases/kernel/mem/hugetlb/hugeshmat/hugeshmat05.c:119:
+ N * hpage_size - page_size -1,
ERROR: space required before the open parenthesis '('
#185: FILE: testcases/kernel/mem/hugetlb/hugeshmat/hugeshmat05.c:127:
+ for(i = 0; i < ARRAY_SIZE(tst_sizes); ++i)
Thanks,
Alexey
prev parent reply other threads:[~2015-12-25 9:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 11:18 [LTP] [PATCH v3] hugetlb: add new testcase hugeshmat05.c Li Wang
2015-12-25 9:09 ` Alexey Kodanev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567D07E7.7040601@oracle.com \
--to=alexey.kodanev@oracle.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox