public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cui Bixuan <cuibixuan@huawei.com>
To: ltp@lists.linux.it
Subject: [LTP] max_map_count fail in arm64 system which support lib32
Date: Wed, 23 Mar 2016 17:00:12 +0800	[thread overview]
Message-ID: <56F25B1C.6070401@huawei.com> (raw)
In-Reply-To: <20160322142842.GE10905@rei.suse.cz>

On 2016/3/22 22:28, Cyril Hrubis wrote:
> Hi!
>> I add a print:
>>
>> #elif defined(__arm__)
>> if (!strncmp(line, "ffff0000-ffff1000", 17))
>>         {
>>                 printf("%s\n", line);  // I add
>>                 return true;
>>         }
>>
>> and then run it(32bit SDK):
> 
> ...
> 
>> So I think:
>> * arm 64bit kernel doesn't have 'special vma VSYSCALL' so no need to skip(32bit binary skip so fail);
>> * arm 32bit kernel have 'special vma VSYSCALL';
> 
> That is what I think as well.
> 
> If you look at the code it does #if defined(__arm__) which is true if
> you compile for 32bit arm, on 64bit __aarch64__ is defined instead.
> 
> Which is why I said we should do runtime check using the machine from
> uname(2) on arm in order to skip the check in case that 32bit arm binary
> runs on 64bit kernel. It should contain something as armvX on 32bit arm
> and aarch64 on 64bit.
Hi,
    I send a patch which uses string check(strstr function) instead of '#if defined' check.
And it contains arm, x86 and ia64.

Thanks,
Cui Bixuan
> 


  parent reply	other threads:[~2016-03-23  9:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-07 11:08 [LTP] max_map_count fail in arm64 system which support lib32 Cui Bixuan
2016-03-22 10:29 ` Cyril Hrubis
2016-03-22 13:49   ` Cui Bixuan
2016-03-22 14:28     ` Cyril Hrubis
2016-03-23  8:53       ` [LTP] [PATCH] max_map_count: fix error by using runtime check Cui Bixuan
2016-03-23 10:22         ` Jan Stancek
2016-03-23 11:59           ` Cui Bixuan
2016-03-31 12:07           ` Cyril Hrubis
2016-04-05 11:47             ` Cui Bixuan
2016-04-11 17:03               ` Cyril Hrubis
2016-04-12  7:15                 ` [LTP] [PATCH v2] " Cui Bixuan
2016-04-12 13:07                   ` Cyril Hrubis
2016-03-23  9:00       ` Cui Bixuan [this message]
2016-12-16  8:25 ` [LTP] [PATCH] max_map_count: fix a mistake and support it for aarch64_be Cui Bixuan
2016-12-16 10:15   ` [LTP] we can ignore it and discuss the problem at 'Fix wrong checking of aarch64' from the_hoang0709@yahoo.com Cui Bixuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F25B1C.6070401@huawei.com \
    --to=cuibixuan@huawei.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox