From: Cui Bixuan <cuibixuan@huawei.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] syscalls/msgctl13: fix error when run on the new system
Date: Wed, 13 Apr 2016 18:27:58 +0800 [thread overview]
Message-ID: <570E1F2E.6060403@huawei.com> (raw)
In-Reply-To: <20160411165848.GA3466@rei.lan>
The msqid is 0 when a new message queue is created by msgget()
on the new system. Then 'TEST(msgget(msg_q, MSG_RW))' succeed
unexpectedly.
Run 'msg_q = msgget(IPC_PRIVATE, MSG_RW)', we get:
msgget(IPC_PRIVATE, 0600) = 0
The msg_q is 0 when create it on the new system.Next:
msgctl(0, IPC_RMID, 0) = 0
msgget(IPC_PRIVATE, 0600) = 32768
The msg_q is equal to IPC_PRIVATE which is defined at kernel,
So msgget() will create a new message queue again and return
success unexpectedly.
Use msgctl with IPC_STAT to check it.
Signed-off-by: Cui Bixuan <cuibixuan@huawei.com>
Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
---
testcases/kernel/syscalls/ipc/msgctl/msgctl13.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/testcases/kernel/syscalls/ipc/msgctl/msgctl13.c b/testcases/kernel/syscalls/ipc/msgctl/msgctl13.c
index e170d6b..50d48d4 100644
--- a/testcases/kernel/syscalls/ipc/msgctl/msgctl13.c
+++ b/testcases/kernel/syscalls/ipc/msgctl/msgctl13.c
@@ -28,6 +28,8 @@
char *TCID = "msgctl13";
int TST_TOTAL = 1;
+static struct msqid_ds buf;
+
static void msgctl_verify(void);
int main(int argc, char *argv[])
@@ -72,8 +74,8 @@ static void msgctl_verify(void)
return;
}
- TEST(msgget(msg_q, MSG_RW));
- if (TEST_ERRNO == ENOENT)
+ TEST(msgctl(msg_q, IPC_STAT, &buf));
+ if (TEST_ERRNO == EINVAL)
tst_resm(TPASS, "msgctl() test IPC_RMID succeeded");
else
tst_resm(TFAIL, "msgctl() test IPC_RMID failed unexpectedly");
--
1.8.3.4
next prev parent reply other threads:[~2016-04-13 10:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-09 7:37 [LTP] [PATCH] syscalls/msgctl13: fix error when run on the new system Cui Bixuan
2016-04-11 16:58 ` Cyril Hrubis
2016-04-13 10:27 ` Cui Bixuan [this message]
2016-04-13 11:09 ` [LTP] [PATCH v2] " Cyril Hrubis
2016-04-13 10:32 ` [LTP] [PATCH] " Cui Bixuan
2016-04-13 10:51 ` Cyril Hrubis
2016-04-14 1:17 ` Cui Bixuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570E1F2E.6060403@huawei.com \
--to=cuibixuan@huawei.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox