From: Cui Bixuan <cuibixuan@huawei.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/msgctl13: fix error when run on the new system
Date: Wed, 13 Apr 2016 18:32:15 +0800 [thread overview]
Message-ID: <570E202F.4090709@huawei.com> (raw)
In-Reply-To: <20160411165848.GA3466@rei.lan>
On 2016/4/12 0:58, Cyril Hrubis wrote:
> This change leaks memory (leaves the message queue with key = 0 on the
> system) and relies on a fact that IPC_PRIVATE == 0 which may not be
> necessarilly true. Can't we instead do IPC_STAT on the msg_q and expect
> it to fail?
Use msgctl with IPC_STAT to check it is better :-);
But why it return EINVAL, instead of EIDRM?
Thanks
Cui Bixuan
>
>
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-04-13 10:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-09 7:37 [LTP] [PATCH] syscalls/msgctl13: fix error when run on the new system Cui Bixuan
2016-04-11 16:58 ` Cyril Hrubis
2016-04-13 10:27 ` [LTP] [PATCH v2] " Cui Bixuan
2016-04-13 11:09 ` Cyril Hrubis
2016-04-13 10:32 ` Cui Bixuan [this message]
2016-04-13 10:51 ` [LTP] [PATCH] " Cyril Hrubis
2016-04-14 1:17 ` Cui Bixuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570E202F.4090709@huawei.com \
--to=cuibixuan@huawei.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox