Re: [LTP] [PATCH 4/4] lib: add tst_res_r.c

Alexey Kodanev
2014-02-13T10:05:30Z

Hi!
On 02/13/2014 12:47 PM, Mike Frysinger wrote:
> On Tuesday, February 11, 2014 13:48:10 Alexey Kodanev wrote:
>> +static int get_tst_count()
> random note: never never never use () with functions. always always always
> use (void). i'm guessing you're not aware, but what you've written here may
> be called (warning free!) like so:
> get_tst_count(1, 2, 3);
>
> yes, even with -W -Wall -Wextra. please stamp this horrible habit out of your
> code.
Thank you for explanation!
There is a trick to try g++ to compile the code, it will throw an error
on that and stops compilation.

Best regards,
Alexey