From: Jiri Jaburek <jjaburek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] ftruncate04 broken on kernels without mandatory locking
Date: Wed, 8 Jun 2016 17:23:01 +0200 [thread overview]
Message-ID: <57583855.9050602@redhat.com> (raw)
Upstream kernel commit
9e8925b67a809bb27ce4b7d352d67f25cf1d7fc5
locks: Allow disabling mandatory locking at compile time
added a config option to remove support for mandatory locking
(mount -o mand, MS_MANDLOCK), which went into v4.5.
Some distributions (like Fedora) already disable it, causing
ftruncate04 to fail:
ftruncate04 0 TINFO : TMPDIR does not support mandatory locks
ftruncate04 0 TINFO : Found free device '/dev/loop0'
ftruncate04 0 TINFO : Formatting /dev/loop0 with ext2 opts=''
extra opts=''
mke2fs 1.42.13 (17-May-2015)
ftruncate04 1 TBROK : safe_macros.c:728: ftruncate04.c:247:
mount(/dev/loop0, dir/, ext2, 64, (nil)) failed: errno=EPERM(1):
Operation not permitted
ftruncate04 2 TBROK : safe_macros.c:728: Remaining cases broken
and indeed
$ mount /dev/loop0 /mnt/
$ umount /mnt
$ mount /dev/loop0 /mnt/ -o mand
mount: permission denied
The question is how to best fix the testcase - do the mount unsafely
and assume EPERM should be TCONF? Or somehow check kernel config?
Maybe do the mount first without MS_MANDLOCK (to rule out other perm
issues) and then remount with MS_MANDLOCK, checking EPERM?
Any other ideas?
Thanks,
Jiri
next reply other threads:[~2016-06-08 15:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 15:23 Jiri Jaburek [this message]
2016-06-09 9:32 ` [LTP] ftruncate04 broken on kernels without mandatory locking Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57583855.9050602@redhat.com \
--to=jjaburek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox