From: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] Shell wrappers for the checkpoint interface
Date: Thu, 9 Jun 2016 14:49:17 +0300 [thread overview]
Message-ID: <575957BD.3000206@oracle.com> (raw)
In-Reply-To: <20160608142344.GD27367@rei.lan>
Hi!
On 06/08/2016 05:23 PM, Cyril Hrubis wrote:
> Hi!
>> + if (!type)
>> + ret = tst_checkpoint_wait(id, timeout);
>> + else
>> + ret = tst_checkpoint_wake(id, nr_wake, timeout);
>
> I find it silly that you do negate the flag here. You could have set it
> the other way, or swap the wait and wake in the if and else branch...
I swapped the wait and wake and pushed it.
Thanks!
>
> Anyway the rest looks good to me, ackend.
>
prev parent reply other threads:[~2016-06-09 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 9:59 [LTP] [PATCH] Shell wrappers for the checkpoint interface Stanislav Kholmanskikh
2016-06-08 14:23 ` Cyril Hrubis
2016-06-09 11:49 ` Stanislav Kholmanskikh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575957BD.3000206@oracle.com \
--to=stanislav.kholmanskikh@oracle.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox