* [LTP] [PATCH] tst_test.h: include tst_kvercmp.h
@ 2016-06-03 12:29 Stanislav Kholmanskikh
2016-06-04 2:29 ` Li Wang
2016-06-06 13:22 ` Cyril Hrubis
0 siblings, 2 replies; 4+ messages in thread
From: Stanislav Kholmanskikh @ 2016-06-03 12:29 UTC (permalink / raw)
To: ltp
tst_kvercmp.h is included in test.h, but is not included in tst_test.h.
Fixed it.
Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
---
include/tst_test.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/tst_test.h b/include/tst_test.h
index 88b46d6..871b273 100644
--- a/include/tst_test.h
+++ b/include/tst_test.h
@@ -31,6 +31,7 @@
#include "tst_cpu.h"
#include "tst_process_state.h"
#include "tst_atomic.h"
+#include "tst_kvercmp.h"
/*
* Reports testcase result.
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [LTP] [PATCH] tst_test.h: include tst_kvercmp.h
2016-06-03 12:29 [LTP] [PATCH] tst_test.h: include tst_kvercmp.h Stanislav Kholmanskikh
@ 2016-06-04 2:29 ` Li Wang
2016-06-06 13:22 ` Cyril Hrubis
1 sibling, 0 replies; 4+ messages in thread
From: Li Wang @ 2016-06-04 2:29 UTC (permalink / raw)
To: ltp
On Fri, Jun 3, 2016 at 8:29 PM, Stanislav Kholmanskikh
<stanislav.kholmanskikh@oracle.com> wrote:
> tst_kvercmp.h is included in test.h, but is not included in tst_test.h.
> Fixed it.
>
> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
> ---
> include/tst_test.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/tst_test.h b/include/tst_test.h
> index 88b46d6..871b273 100644
> --- a/include/tst_test.h
> +++ b/include/tst_test.h
> @@ -31,6 +31,7 @@
> #include "tst_cpu.h"
> #include "tst_process_state.h"
> #include "tst_atomic.h"
> +#include "tst_kvercmp.h"
In the tst_test.h file, there have achieved a kernel comparative method:
struct tst_test {
...
const char *min_kver;
...
};
but sometimes we have to make choice in a specific condition
judgement, so it would be better to include that and remove the line:
#include "tst_kvercmp.h" from other place(ie.
/kernel/syscalls/madvise/madvise06.c) at the same time.
--
Regards,
Li Wang
Email: liwang@redhat.com
^ permalink raw reply [flat|nested] 4+ messages in thread* [LTP] [PATCH] tst_test.h: include tst_kvercmp.h
2016-06-03 12:29 [LTP] [PATCH] tst_test.h: include tst_kvercmp.h Stanislav Kholmanskikh
2016-06-04 2:29 ` Li Wang
@ 2016-06-06 13:22 ` Cyril Hrubis
2016-06-09 12:06 ` Stanislav Kholmanskikh
1 sibling, 1 reply; 4+ messages in thread
From: Cyril Hrubis @ 2016-06-06 13:22 UTC (permalink / raw)
To: ltp
Hi!
> tst_kvercmp.h is included in test.h, but is not included in tst_test.h.
> Fixed it.
We should remove the include from lib/tst_test.c in this patch as well.
Other than that acked.
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 4+ messages in thread
* [LTP] [PATCH] tst_test.h: include tst_kvercmp.h
2016-06-06 13:22 ` Cyril Hrubis
@ 2016-06-09 12:06 ` Stanislav Kholmanskikh
0 siblings, 0 replies; 4+ messages in thread
From: Stanislav Kholmanskikh @ 2016-06-09 12:06 UTC (permalink / raw)
To: ltp
Hi!
On 06/06/2016 04:22 PM, Cyril Hrubis wrote:
> Hi!
>> tst_kvercmp.h is included in test.h, but is not included in tst_test.h.
>> Fixed it.
>
> We should remove the include from lib/tst_test.c in this patch as well.
>
> Other than that acked.
>
Li, Cyril, the patch was updated to remove all explicit includes of
tst_kvercmp.h in .c files and pushed.
Thank you for your feedback.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-09 12:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-03 12:29 [LTP] [PATCH] tst_test.h: include tst_kvercmp.h Stanislav Kholmanskikh
2016-06-04 2:29 ` Li Wang
2016-06-06 13:22 ` Cyril Hrubis
2016-06-09 12:06 ` Stanislav Kholmanskikh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox