public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Alexey Kodanev <alexey.kodanev@oracle.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] lib: add safe_gethostname()
Date: Thu, 23 Jun 2016 14:58:45 +0300	[thread overview]
Message-ID: <576BCEF5.3090509@oracle.com> (raw)
In-Reply-To: <20160622120535.GB13962@rei.lan>

On 06/22/2016 03:05 PM, Cyril Hrubis wrote:
> Hi!
>> Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
>> ---
>>   include/safe_net_fn.h  |    3 +++
>>   include/tst_safe_net.h |    3 +++
>>   lib/safe_net.c         |   14 ++++++++++++++
>>   3 files changed, 20 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/safe_net_fn.h b/include/safe_net_fn.h
>> index e85842b..14609b8 100644
>> --- a/include/safe_net_fn.h
>> +++ b/include/safe_net_fn.h
>> @@ -45,4 +45,7 @@ int safe_getsockname(const char *file, const int lineno,
>>   		     void (cleanup_fn)(void), int sockfd, struct sockaddr *addr,
>>   		     socklen_t *addrlen);
>>   
>> +int safe_gethostname(const char *file, const int lineno,
>> +		     void (cleanup_fn)(void), char *name, size_t size);
>> +
> What about not including the cleanup_fn parameter, since the function is
> exported only to new library?

Yes, in newlib it's not used, I'll remove it.

Thanks,
Alexey

      reply	other threads:[~2016-06-23 11:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16 11:27 [LTP] [PATCH 1/2] lib: add safe_gethostname() Alexey Kodanev
2016-06-16 11:27 ` [LTP] [PATCH 2/2] nfs05: rewrite the test, make use of new library Alexey Kodanev
2016-06-22 12:30   ` Cyril Hrubis
2016-06-23 11:56     ` Alexey Kodanev
2016-06-23 11:54       ` Cyril Hrubis
2016-06-23 12:38         ` Alexey Kodanev
2016-06-23 12:41           ` Cyril Hrubis
2016-06-22 12:05 ` [LTP] [PATCH 1/2] lib: add safe_gethostname() Cyril Hrubis
2016-06-23 11:58   ` Alexey Kodanev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=576BCEF5.3090509@oracle.com \
    --to=alexey.kodanev@oracle.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox