public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Alexey Kodanev <alexey.kodanev@oracle.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] nfs05: rewrite the test, make use of new library
Date: Thu, 23 Jun 2016 15:38:11 +0300	[thread overview]
Message-ID: <576BD833.7020502@oracle.com> (raw)
In-Reply-To: <20160623115438.GB19250@rei.lan>

On 06/23/2016 02:54 PM, Cyril Hrubis wrote:
> Hi!
>>>>    
>>>> -			dprt("pid[%d]: init_compile(): status = %d\n",
>>>> -			     gettid(), status);
>>>> -			dprt("we are here %d\n", __LINE__);
>>>> -			return status;
>>>> +			SAFE_WRITE(1, fd, prog_buf, prog_buf_size);
>>>> +			fsync(fd);
>>> Why do we fsync(fd) here? Isn't the whole point of this test to find a
>>> race conditions?
>> And given the fact that we have close(fd) thereafter, should make it
>> useless...
> fsync() should cause the page caches to be written to the disk, close()
> just frees the associated file descriptor and page caches are written on
> background.
In case of NFS?


  reply	other threads:[~2016-06-23 12:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16 11:27 [LTP] [PATCH 1/2] lib: add safe_gethostname() Alexey Kodanev
2016-06-16 11:27 ` [LTP] [PATCH 2/2] nfs05: rewrite the test, make use of new library Alexey Kodanev
2016-06-22 12:30   ` Cyril Hrubis
2016-06-23 11:56     ` Alexey Kodanev
2016-06-23 11:54       ` Cyril Hrubis
2016-06-23 12:38         ` Alexey Kodanev [this message]
2016-06-23 12:41           ` Cyril Hrubis
2016-06-22 12:05 ` [LTP] [PATCH 1/2] lib: add safe_gethostname() Cyril Hrubis
2016-06-23 11:58   ` Alexey Kodanev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=576BD833.7020502@oracle.com \
    --to=alexey.kodanev@oracle.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox