From: Shuang Qiu <shuang.qiu@oracle.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] controllers/cpuset:check for cpuset mount status and prefix
Date: Sun, 24 Jul 2016 07:34:08 +0800 [thread overview]
Message-ID: <5793FEF0.7090203@oracle.com> (raw)
In-Reply-To: <757741255.7369133.1469193307743.JavaMail.zimbra@redhat.com>
On 07/22/2016 09:15 PM, Jan Stancek wrote:
>
>
>
> ----- Original Message -----
>> From: "shuang qiu" <shuang.qiu@oracle.com>
>> To: ltp@lists.linux.it
>> Sent: Thursday, 14 July, 2016 8:54:00 AM
>> Subject: [LTP] [PATCH] controllers/cpuset:check for cpuset mount status and prefix
>>
>> From: Shuang Qiu <shuang.qiu@oracle.com>
>>
>> * Update to handle the env that cpuset subsystem is already mounted
> I'm assuming motivation here are systemd distros, that have memory
> cgroup already mounted.
Yes,such like RHEL7 or OL7,it is mounted by default.
But also another scenario that on RHEL6 or OL6 with cgconfig service
running.
>
>> * Similar with commit 6ce94db5bbff0be40813f3fdfe61a55b3186c49a,need to check
>> for cpuset prefix
>>
>> Signed-off-by: Shuang Qiu <shuang.qiu@oracle.com>
>> ---
>> .../cpuset_base_ops_testset.sh | 28 +-
>> .../cpuset_exclusive_test/cpuset_exclusive_test.sh | 168 ++++----
>> .../kernel/controllers/cpuset/cpuset_funcs.sh | 39 +-
>> .../cpuset_hierarchy_test/cpuset_hierarchy_test.sh | 416
>> ++++++++++----------
>> .../cpuset_hotplug_test/cpuset_hotplug_test.sh | 4 +-
>> .../cpuset_inherit_test/cpuset_inherit_testset.sh | 12 +-
>> .../cpuset_memory_pressure_testset.sh | 32 +-
>> .../cpuset_memory_spread_testset.sh | 2 +-
>> .../cpuset_memory_test/cpuset_memory_testset.sh | 22 +-
>> .../cpuset_syscall_test/cpuset_syscall_testset.sh | 8 +-
>> 10 files changed, 369 insertions(+), 362 deletions(-)
> Looks OK to me. The changes look straight-forward, there's just
> lot of them.
>
> I've ran it on RHEL7.3 and these passed. I tried also upstream
> 4.7-rc7 and there were some failures, but that seems to be
> because some input validation has changed on some files.
>
> Can you also mention where/how you tested this change?
I just tested on OL7.2 and OL6.8 with cgconfig service start or stop.
There were also some failures but not related with mount or prefix,I'm
still checking them.
Thanks for review
Shuang
>
> Thanks,
> Jan
next prev parent reply other threads:[~2016-07-23 23:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 6:54 [LTP] [PATCH] controllers/cpuset:check for cpuset mount status and prefix shuang.qiu
2016-07-22 13:15 ` Jan Stancek
2016-07-23 23:34 ` Shuang Qiu [this message]
2017-04-11 6:32 ` charishma
2017-04-18 10:00 ` Jan Stancek
2017-04-20 12:15 ` Cyril Hrubis
2017-04-20 12:11 ` Cyril Hrubis
2017-04-22 8:30 ` Shuang Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5793FEF0.7090203@oracle.com \
--to=shuang.qiu@oracle.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox