From: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] syscalls/access04: reconstruct and convert to new API
Date: Fri, 5 Aug 2016 18:08:35 +0800 [thread overview]
Message-ID: <57A465A3.8020306@cn.fujitsu.com> (raw)
In-Reply-To: <20160804165028.GD3367@rei.lan>
Hi!
Thanks for your comments!
On 08/05/2016 12:50 AM, Cyril Hrubis wrote:
> Hi!
> Once we remote the directory the accessfile is in this is just the same
> as access01.c.
>
Sorry, do you mean once we "remote" the directory? or "remove" the directory?
And I think access04 does a little more: checks if the file exists actually
via stat(), maybe I should add this part(check existence) to access02?
> Looks like the whole point of the test was to put the file into a
> directory and pass the path to the syscall.
>
> What about we remote this test and add a few more cases with a file in
> subdirectory to the access01 test instead?
>
OK, I will put this part into access01 and add a few more cases instead, thanks.
Regards,
Guangwen Feng
next prev parent reply other threads:[~2016-08-05 10:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 9:38 [LTP] [PATCH 1/2] syscalls/access04: reconstruct and convert to new API Guangwen Feng
2016-07-28 9:38 ` [LTP] [PATCH 2/2] syscalls/access05: " Guangwen Feng
2016-09-09 7:31 ` Guangwen Feng
2016-09-22 15:47 ` Cyril Hrubis
2016-08-04 16:50 ` [LTP] [PATCH 1/2] syscalls/access04: " Cyril Hrubis
2016-08-05 10:08 ` Guangwen Feng [this message]
2016-08-09 13:14 ` Cyril Hrubis
2016-08-19 9:19 ` [LTP] [PATCH 1/2] syscalls/access01: add testcases with files in subdirectory Guangwen Feng
2016-08-19 9:19 ` [LTP] [PATCH 2/2] syscalls/access02: add behaviour check for F_OK Guangwen Feng
2016-08-24 14:44 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57A465A3.8020306@cn.fujitsu.com \
--to=fenggw-fnst@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox