public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Alexey Kodanev <alexey.kodanev@oracle.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 2/2] network/nfs05: rewrite the test, make use of new library
Date: Tue, 16 Aug 2016 19:01:46 +0300	[thread overview]
Message-ID: <57B338EA.1000707@oracle.com> (raw)
In-Reply-To: <20160816153417.GF25540@rei.lan>

Hi,
On 08/16/2016 06:34 PM, Cyril Hrubis wrote:
> Hi!
>>   tst_resm TINFO "start nfs05_make_tree -d $DIR_NUM -f $FILE_NUM -t $THREAD_NUM"
>> -ROD nfs05_make_tree -d $DIR_NUM -f $FILE_NUM -t $THREAD_NUM
>> +TMPDIR=$(pwd) nfs05_make_tree -d $DIR_NUM -f $FILE_NUM -t $THREAD_NUM
> Hmm, the tst_tmpdir is created and mounted in the nfs_setup right?
>
> Why can't we just let the nfs05_make_tree work with current
> directory and omit the needs_tmpdir = 1 from it's source? It's not like
> the nfs05_make_tree binary is supposed to be executed directly, so it's
> OK if it starts to create files in PWD.

You are right, it's not used other than inside nfs05 script so the flag 
can be
safely removed along with "TMPDIR=$(pwd)".

Thanks,
Alexey

  reply	other threads:[~2016-08-16 16:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-28 16:00 [LTP] [PATCH v2 1/2] lib: add safe_gethostname() Alexey Kodanev
2016-06-28 16:00 ` [LTP] [PATCH v2 2/2] network/nfs05: rewrite the test, make use of new library Alexey Kodanev
2016-08-16 15:34   ` Cyril Hrubis
2016-08-16 16:01     ` Alexey Kodanev [this message]
2016-08-18 12:09       ` Alexey Kodanev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57B338EA.1000707@oracle.com \
    --to=alexey.kodanev@oracle.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox