From: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/8] waitpid10: use the new API
Date: Thu, 18 Aug 2016 11:25:38 +0300 [thread overview]
Message-ID: <57B57102.1010305@oracle.com> (raw)
In-Reply-To: <20160815143602.GF20680@rei.lan>
On 08/15/2016 05:36 PM, Cyril Hrubis wrote:
> Hi!
>> +static void do_child_1(void)
>> {
>
> Why do we run the test in the do_child_1() here?
>
> As far as I remember the whole point was to start some of the child
> processes in different process group and we don't do that in this test,
> so we may as well put this function as the test function into the struct
> tst_test.
waitpid_test() just forks a child - do_child_1() which then does the
actual testing. This scheme is needed in other test cases, since they
operate with process groups.
Yes, here it's redundant, since this do_child_1() doesn't touch process
groups. I decided to use this scheme here just for similarity with other
test cases. In my opinion, it brings no harm or improvements.
>
>
> Otherwise this looks good.
>
next prev parent reply other threads:[~2016-08-18 8:25 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 8:40 [LTP] waitpid: new API (part 2) Stanislav Kholmanskikh
2016-08-10 8:40 ` [LTP] [PATCH 1/8] waitpid09: use the new API Stanislav Kholmanskikh
2016-08-10 8:41 ` [LTP] [PATCH 2/8] waitpid10: " Stanislav Kholmanskikh
2016-08-10 8:41 ` [LTP] [PATCH 3/8] syscalls/waitpid: implement waitpid_ret_test() Stanislav Kholmanskikh
2016-08-10 8:41 ` [LTP] [PATCH 4/8] syscalls/waitpid: make reap_children() fail if errno is not ECHILD Stanislav Kholmanskikh
2016-08-10 8:41 ` [LTP] [PATCH 5/8] waitpid11: update the description Stanislav Kholmanskikh
2016-08-10 8:41 ` [LTP] [PATCH 6/8] waitpid12: use the new API Stanislav Kholmanskikh
2016-08-10 8:41 ` [LTP] [PATCH 7/8] waitpid13: " Stanislav Kholmanskikh
2016-08-10 8:41 ` [LTP] [PATCH 8/8] waitpid08: test stopped children Stanislav Kholmanskikh
2016-08-16 13:03 ` Cyril Hrubis
2016-08-18 10:12 ` Stanislav Kholmanskikh
2016-08-18 10:48 ` Cyril Hrubis
2016-08-18 11:37 ` Stanislav Kholmanskikh
2016-08-16 13:24 ` [LTP] [PATCH 7/8] waitpid13: use the new API Cyril Hrubis
2016-08-16 13:20 ` [LTP] [PATCH 6/8] waitpid12: " Cyril Hrubis
2016-08-15 15:51 ` [LTP] [PATCH 5/8] waitpid11: update the description Cyril Hrubis
2016-08-15 15:49 ` [LTP] [PATCH 4/8] syscalls/waitpid: make reap_children() fail if errno is not ECHILD Cyril Hrubis
2016-08-15 15:27 ` [LTP] [PATCH 3/8] syscalls/waitpid: implement waitpid_ret_test() Cyril Hrubis
2016-08-18 9:54 ` Stanislav Kholmanskikh
2016-08-18 10:42 ` Cyril Hrubis
2016-08-18 15:15 ` Stanislav Kholmanskikh
2016-08-18 15:43 ` Cyril Hrubis
2016-08-18 15:54 ` Cyril Hrubis
2016-08-19 9:47 ` Stanislav Kholmanskikh
2016-08-22 17:38 ` Cyril Hrubis
2016-08-15 14:36 ` [LTP] [PATCH 2/8] waitpid10: use the new API Cyril Hrubis
2016-08-18 8:25 ` Stanislav Kholmanskikh [this message]
2016-08-18 8:33 ` Stanislav Kholmanskikh
2016-08-18 9:19 ` Cyril Hrubis
2016-08-15 13:55 ` [LTP] [PATCH 1/8] waitpid09: " Cyril Hrubis
2016-08-18 7:40 ` [LTP] [PATCH 1/8 V2] " Stanislav Kholmanskikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57B57102.1010305@oracle.com \
--to=stanislav.kholmanskikh@oracle.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox