public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Alexey Kodanev <alexey.kodanev@oracle.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] network/nfs05_make_tree: Pass -D_GNU_SOURCE to enable O_DIRECTORY
Date: Fri, 19 Aug 2016 14:22:32 +0300	[thread overview]
Message-ID: <57B6EBF8.1060407@oracle.com> (raw)
In-Reply-To: <1471542167-5118-1-git-send-email-yuriy.kolerov@synopsys.com>

Hi,
On 08/18/2016 08:42 PM, Yuriy Kolerov wrote:
> This test uses O_DIRECTORY macro and in some standard libraries it
> may be defined only if _GNU_SOURCE is enabled.
>
> Signed-off-by: Yuriy Kolerov <yuriy.kolerov@synopsys.com>
> ---
>   testcases/network/nfs/nfs_stress/Makefile | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/testcases/network/nfs/nfs_stress/Makefile b/testcases/network/nfs/nfs_stress/Makefile
> index 3162cea..2fde4cb 100644
> --- a/testcases/network/nfs/nfs_stress/Makefile
> +++ b/testcases/network/nfs/nfs_stress/Makefile
> @@ -20,6 +20,7 @@ include $(top_srcdir)/include/mk/testcases.mk
>   
>   nfs04_create_file: CPPFLAGS += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
>   nfs05_make_tree: LDLIBS += -lpthread
> +nfs05_make_tree: CPPFLAGS += -D_GNU_SOURCE

Right, but the preferred way is to define this macro in the source file, 
before any #include.
Could you make a new patch with the fix in nfs05_make_tree.c?

Thanks,
Alexey


      reply	other threads:[~2016-08-19 11:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-18 17:42 [LTP] [PATCH] network/nfs05_make_tree: Pass -D_GNU_SOURCE to enable O_DIRECTORY Yuriy Kolerov
2016-08-19 11:22 ` Alexey Kodanev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57B6EBF8.1060407@oracle.com \
    --to=alexey.kodanev@oracle.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox