* [LTP] [PATCH] network/nfs05_make_tree: Pass -D_GNU_SOURCE to enable O_DIRECTORY
@ 2016-08-18 17:42 Yuriy Kolerov
2016-08-19 11:22 ` Alexey Kodanev
0 siblings, 1 reply; 2+ messages in thread
From: Yuriy Kolerov @ 2016-08-18 17:42 UTC (permalink / raw)
To: ltp
This test uses O_DIRECTORY macro and in some standard libraries it
may be defined only if _GNU_SOURCE is enabled.
Signed-off-by: Yuriy Kolerov <yuriy.kolerov@synopsys.com>
---
testcases/network/nfs/nfs_stress/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/testcases/network/nfs/nfs_stress/Makefile b/testcases/network/nfs/nfs_stress/Makefile
index 3162cea..2fde4cb 100644
--- a/testcases/network/nfs/nfs_stress/Makefile
+++ b/testcases/network/nfs/nfs_stress/Makefile
@@ -20,6 +20,7 @@ include $(top_srcdir)/include/mk/testcases.mk
nfs04_create_file: CPPFLAGS += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
nfs05_make_tree: LDLIBS += -lpthread
+nfs05_make_tree: CPPFLAGS += -D_GNU_SOURCE
INSTALL_TARGETS := nfs_lib.sh \
nfs01 \
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [LTP] [PATCH] network/nfs05_make_tree: Pass -D_GNU_SOURCE to enable O_DIRECTORY
2016-08-18 17:42 [LTP] [PATCH] network/nfs05_make_tree: Pass -D_GNU_SOURCE to enable O_DIRECTORY Yuriy Kolerov
@ 2016-08-19 11:22 ` Alexey Kodanev
0 siblings, 0 replies; 2+ messages in thread
From: Alexey Kodanev @ 2016-08-19 11:22 UTC (permalink / raw)
To: ltp
Hi,
On 08/18/2016 08:42 PM, Yuriy Kolerov wrote:
> This test uses O_DIRECTORY macro and in some standard libraries it
> may be defined only if _GNU_SOURCE is enabled.
>
> Signed-off-by: Yuriy Kolerov <yuriy.kolerov@synopsys.com>
> ---
> testcases/network/nfs/nfs_stress/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/testcases/network/nfs/nfs_stress/Makefile b/testcases/network/nfs/nfs_stress/Makefile
> index 3162cea..2fde4cb 100644
> --- a/testcases/network/nfs/nfs_stress/Makefile
> +++ b/testcases/network/nfs/nfs_stress/Makefile
> @@ -20,6 +20,7 @@ include $(top_srcdir)/include/mk/testcases.mk
>
> nfs04_create_file: CPPFLAGS += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
> nfs05_make_tree: LDLIBS += -lpthread
> +nfs05_make_tree: CPPFLAGS += -D_GNU_SOURCE
Right, but the preferred way is to define this macro in the source file,
before any #include.
Could you make a new patch with the fix in nfs05_make_tree.c?
Thanks,
Alexey
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-19 11:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-18 17:42 [LTP] [PATCH] network/nfs05_make_tree: Pass -D_GNU_SOURCE to enable O_DIRECTORY Yuriy Kolerov
2016-08-19 11:22 ` Alexey Kodanev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox