public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 3/4] memcg_lib.sh: Get rid of sleep 1 in signal_memcg_process
Date: Thu, 8 Sep 2016 11:38:08 +0300	[thread overview]
Message-ID: <57D12370.9000803@oracle.com> (raw)
In-Reply-To: <20160907101902.GA14864@rei.suse.cz>



On 09/07/2016 01:19 PM, Cyril Hrubis wrote:
> Hi!
>> A side note.
>>
>> In fact, in LTP we use 'local' in test cases written for '/bin/sh',
>> whereas 'local' is not in POSIX. Maybe document this fact in the test
>> writing guidelines?
> 
> Something like that?

Yes.

> 
> diff --git a/doc/test-writing-guidelines.txt b/doc/test-writing-guidelines.txt
> index c7d301f..f927fc6 100644
> --- a/doc/test-writing-guidelines.txt
> +++ b/doc/test-writing-guidelines.txt
> @@ -61,6 +61,11 @@ When writing testcases in shell write in *portable shell* only, it's a good
>  idea to try to run the test using alternative shell (alternative to bash, for
>  example dash) too.
> 
> +*Portable shell* means Shell Command Language as defined by POSIX with a
> +exception of few widely used extensions, namely 'local' keyword used inside of
> +functions and '-o' and '-a' test parameters (that are marked as obsolete in
> +POSIX).
> +
>  You can either try to run the testcases on Debian which has '/bin/sh' pointing
>  to 'dash' by default or install 'dash' on your favorite distribution and use
>  it to run the tests. If your distribution lacks 'dash' package you can always
> 

  reply	other threads:[~2016-09-08  8:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-01 17:18 [LTP] [PATCH 1/4] memcg_lib.sh: Print test number at test start Cyril Hrubis
2016-09-01 17:18 ` [LTP] [PATCH 2/4] memcg_lib.sh: Move all the kill -s XXX to functions Cyril Hrubis
2016-09-02  9:27   ` Stanislav Kholmanskikh
2016-09-01 17:18 ` [LTP] [PATCH 3/4] memcg_lib.sh: Get rid of sleep 1 in signal_memcg_process Cyril Hrubis
2016-09-02  9:42   ` Stanislav Kholmanskikh
2016-09-05 10:18     ` Jan Stancek
2016-09-05 12:10       ` Cyril Hrubis
2016-09-05 12:50     ` Cyril Hrubis
2016-09-07 10:19     ` Cyril Hrubis
2016-09-08  8:38       ` Stanislav Kholmanskikh [this message]
2016-09-01 17:18 ` [LTP] [PATCH 4/4] memcg_function_test.sh: Split Cyril Hrubis
2016-09-02 10:28   ` Stanislav Kholmanskikh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57D12370.9000803@oracle.com \
    --to=stanislav.kholmanskikh@oracle.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox