* [LTP] [PATCH 1/1] network: portability: using tst_sleep instead of usleep
@ 2016-11-08 16:13 Petr Vorel
2016-11-09 11:43 ` Alexey Kodanev
0 siblings, 1 reply; 2+ messages in thread
From: Petr Vorel @ 2016-11-08 16:13 UTC (permalink / raw)
To: ltp
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
testcases/network/dhcp/dhcp_lib.sh | 4 ++--
testcases/network/tcp_cmds/ipneigh/ipneigh01.sh | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/testcases/network/dhcp/dhcp_lib.sh b/testcases/network/dhcp/dhcp_lib.sh
index 140619d..85f9b88 100755
--- a/testcases/network/dhcp/dhcp_lib.sh
+++ b/testcases/network/dhcp/dhcp_lib.sh
@@ -26,12 +26,12 @@ stop_dhcp()
while [ $count -le 10 ]; do
pkill -x $dhcp_name
[ "$(pgrep -x $dhcp_name)" ] || return 0
- usleep 100000
+ tst_sleep 100ms
count=$((count + 1))
done
pkill -9 -x $dhcp_name
- usleep 100000
+ tst_sleep 100ms
[ "$(pgrep -x $dhcp_name)" ] && return 1 || return 0
}
diff --git a/testcases/network/tcp_cmds/ipneigh/ipneigh01.sh b/testcases/network/tcp_cmds/ipneigh/ipneigh01.sh
index 736d149..31d6cc6 100755
--- a/testcases/network/tcp_cmds/ipneigh/ipneigh01.sh
+++ b/testcases/network/tcp_cmds/ipneigh/ipneigh01.sh
@@ -52,7 +52,7 @@ do_test()
ret=0
break;
fi
- usleep 100
+ tst_sleep 100us
done
[ "$ret" -ne 0 ] && \
--
2.10.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [LTP] [PATCH 1/1] network: portability: using tst_sleep instead of usleep
2016-11-08 16:13 [LTP] [PATCH 1/1] network: portability: using tst_sleep instead of usleep Petr Vorel
@ 2016-11-09 11:43 ` Alexey Kodanev
0 siblings, 0 replies; 2+ messages in thread
From: Alexey Kodanev @ 2016-11-09 11:43 UTC (permalink / raw)
To: ltp
Hi,
On 11/08/2016 07:13 PM, Petr Vorel wrote:
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> testcases/network/dhcp/dhcp_lib.sh | 4 ++--
> testcases/network/tcp_cmds/ipneigh/ipneigh01.sh | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/testcases/network/dhcp/dhcp_lib.sh b/testcases/network/dhcp/dhcp_lib.sh
> index 140619d..85f9b88 100755
> --- a/testcases/network/dhcp/dhcp_lib.sh
> +++ b/testcases/network/dhcp/dhcp_lib.sh
> @@ -26,12 +26,12 @@ stop_dhcp()
> while [ $count -le 10 ]; do
> pkill -x $dhcp_name
> [ "$(pgrep -x $dhcp_name)" ] || return 0
> - usleep 100000
> + tst_sleep 100ms
> count=$((count + 1))
> done
>
> pkill -9 -x $dhcp_name
> - usleep 100000
> + tst_sleep 100ms
> [ "$(pgrep -x $dhcp_name)" ] && return 1 || return 0
> }
>
> diff --git a/testcases/network/tcp_cmds/ipneigh/ipneigh01.sh b/testcases/network/tcp_cmds/ipneigh/ipneigh01.sh
> index 736d149..31d6cc6 100755
> --- a/testcases/network/tcp_cmds/ipneigh/ipneigh01.sh
> +++ b/testcases/network/tcp_cmds/ipneigh/ipneigh01.sh
> @@ -52,7 +52,7 @@ do_test()
> ret=0
> break;
> fi
> - usleep 100
> + tst_sleep 100us
Patch applied. I've changed sleep time here to 'ms', it should have been
"usleep 100000", so the patch is fixing it as well,
added comment about this in the patch.
Thanks,
Alexey
> done
>
> [ "$ret" -ne 0 ] && \
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-09 11:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-08 16:13 [LTP] [PATCH 1/1] network: portability: using tst_sleep instead of usleep Petr Vorel
2016-11-09 11:43 ` Alexey Kodanev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox