From: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/getpriority01: exclude default priority check for PRIO_USER.
Date: Tue, 22 Nov 2016 17:34:33 +0800 [thread overview]
Message-ID: <58341129.4000003@cn.fujitsu.com> (raw)
In-Reply-To: <20161122085616.GB7048@rei.lan>
Hi!
Thanks for your review.
On 11/22/2016 04:56 PM, Cyril Hrubis wrote:
> Hi!
>> The current user priority is various when testing,
>> we should not check it as default value.
>
> What system does this happen on? It should probably be mentioned in the
> commit message.
It happens on Fedora20, RHEL5.11GA, RHEL6.8GA, RNEL7.3GA, testing returns
-20 and -11 for PRIO_USER as root and nobody respectively.
>
> And we should probably as well just revert the change I've did and check
> only that errno wasn't set since the value may be set even to -1.
I think so, checking "TEST_ERRNO != 0" is adequate for the case.
Best Regards,
Guangwen Feng
next prev parent reply other threads:[~2016-11-22 9:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 6:02 [LTP] [PATCH] syscalls/getpriority01: exclude default priority check for PRIO_USER Guangwen Feng
2016-11-22 8:56 ` Cyril Hrubis
2016-11-22 9:34 ` Guangwen Feng [this message]
2016-11-22 9:37 ` Cyril Hrubis
2016-11-23 6:26 ` Guangwen Feng
2016-11-23 15:04 ` Cyril Hrubis
2016-11-24 7:02 ` Guangwen Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58341129.4000003@cn.fujitsu.com \
--to=fenggw-fnst@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox