public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Alexey Kodanev <alexey.kodanev@oracle.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH][RFC] network: test_net.sh: allow to run tests on a single machine
Date: Tue, 22 Nov 2016 13:35:39 +0300	[thread overview]
Message-ID: <58341F7B.8040108@oracle.com> (raw)
In-Reply-To: <20161122083841.GA7048@rei.lan>

Hi,

On 11/22/2016 11:38 AM, Cyril Hrubis wrote:
> Hi!
>> When 'TST_USE_NETNS' environment variable is defined, test_net.sh
>> will setup 'ltp_ns' netns and configure veth pair according to
>> other LTP network variables. Then, each tst_rhost_run() call will
>> be executed in the new netns on the same host.
>>
>> Usage:
>> TST_USE_NETNS=1... ./network.sh -i
> Looks like a smart idea to me, the implementation looks ok as well. I
> wonder if we should add these kind of network tests into default
> scenario...

Some test groups can be added and I guess we should default to netns 
configuration
if RHOST variable isn't defined. This way the tests won't require any 
network
environment variables set beforehand.

> The patch misses any documentation though, it should be described
> properly somewhere.

Right, will add it and send a new version.


Thanks,
Alexey


      reply	other threads:[~2016-11-22 10:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-14 13:33 [LTP] [PATCH][RFC] network: test_net.sh: allow to run tests on a single machine Alexey Kodanev
2016-11-22  8:38 ` Cyril Hrubis
2016-11-22 10:35   ` Alexey Kodanev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58341F7B.8040108@oracle.com \
    --to=alexey.kodanev@oracle.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox