public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Alexey Kodanev <alexey.kodanev@oracle.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] network/echoes: fix endless loop on error
Date: Thu, 15 Dec 2016 14:48:46 +0300	[thread overview]
Message-ID: <5852831E.6070608@oracle.com> (raw)
In-Reply-To: <20161214170604.nycf5yipmdvcyss7@dell5510>

Hi Petr,
On 14.12.2016 20:06, Petr Vorel wrote:
> Hi Alexey,
>
>> Good catch, looks like we could substitute the while loop here with
>> tst_reap_children() library function and remove "echo_struc" as well?
> Could you please push this quick fix? I plan to rewrite test into new API, but probably
> will not manage it until the release.

OK,  but if we want a quick fix here we can just add a single "break" 
after the loop where
it is killing all the left child processes. No need to proceed anyway. 
If you agree I'll push
the patch with the break version:

--- a/testcases/network/tcp_cmds/echo/echoes.c
+++ b/testcases/network/tcp_cmds/echo/echoes.c
@@ -121,7 +121,7 @@ int main(int argc, char *argv[], char *env[])
                                         kill(echo_struc[k].pid, 9);
                                 }
                         }
-
+                       break;
                 }

         }

Thanks,
Alexey

  reply	other threads:[~2016-12-15 11:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-29 16:02 [LTP] [PATCH 1/1] network/echoes: fix endless loop on error Petr Vorel
2016-12-06 10:53 ` Alexey Kodanev
2016-12-06 13:58   ` Petr Vorel
2016-12-14 17:06   ` Petr Vorel
2016-12-15 11:48     ` Alexey Kodanev [this message]
     [not found]       ` <20161215115111.srk5fmrehsllbhuw@x230>
2016-12-15 12:12         ` Alexey Kodanev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5852831E.6070608@oracle.com \
    --to=alexey.kodanev@oracle.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox