public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/mq_open: fix limits for queues_max
Date: Thu, 16 Feb 2017 09:20:23 +0800	[thread overview]
Message-ID: <58A4FE57.1040109@cn.fujitsu.com> (raw)
In-Reply-To: <20170215152406.GB29673@rei.lan>

On 2017/02/15 23:24, Cyril Hrubis wrote:
> Hi!
>> This case fails on RHEL6.8GA and RHEL6.9Beta, because setting
>> queues_max to 0 is invalid.  the minimum value of queues_max
>> has been limitted to 1 on some distributions, Please see the
>> following kernel commit:
>>
>> commit 5b5c4d1a1440e94994c73dddbad7be0676cd8b9a
>> Author: Doug Ledford<dledford@redhat.com>
>> Date:   Thu May 31 16:26:30 2012 -0700
>>
>> 	ipc/mqueue: update maximums for the mqueue subsystem
>>
>> We set queues_max to 1 instead of 0, so this case can work on RHEL6.
> First I think that you have wrong commit, the one that actually added
> the limits was:
>
> commit 93e6f119c0ce8a1bba6e81dc8dd97d67be360844
> Author: Doug Ledford<dledford@redhat.com>
> Date:   Thu May 31 16:26:28 2012 -0700
>
>      ipc/mqueue: cleanup definition names and locations
>
> Since this commit changes the proc handler in sysctl table and adds the minimum
> and maximum values there.
>
> Secondly these limits were removed in:
>
> commit a5c5928b759d8c7382cccc7be36769a68046cc58
> Author: Joe Perches<joe@perches.com>
> Date:   Fri Jun 6 14:38:07 2014 -0700
>
>      ipc: convert use of typedef ctl_table to struct ctl_table
>
Hi Cyril

Thanks for your review.
I will change commit as you said and send v2 patch.

Best Regards,
Xiao Yang
> I'm not sure if this is worth the effort.
>
> Jan what do you think, should we apply this to fix the test on RHEL6?
>




  parent reply	other threads:[~2017-02-16  1:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-06 12:42 [LTP] [PATCH] syscalls/mq_open: fix limits for queues_max Xiao Yang
2017-02-15  1:26 ` Xiao Yang
2017-02-15 15:24 ` Cyril Hrubis
2017-02-15 16:50   ` Jan Stancek
2017-02-15 18:19     ` Jan Stancek
2017-02-16  9:37       ` Cyril Hrubis
2017-02-16  1:20   ` Xiao Yang [this message]
2017-02-16  2:38   ` [LTP] [PATCH v2] " Xiao Yang
2017-02-16  9:28     ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58A4FE57.1040109@cn.fujitsu.com \
    --to=yangx.jy@cn.fujitsu.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox