From: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/memfd_create: Fix build fail when HAVE_FALLOCATE not defined
Date: Thu, 30 Mar 2017 17:49:37 +0800 [thread overview]
Message-ID: <58DCD4B1.5060705@cn.fujitsu.com> (raw)
In-Reply-To: <20170330093540.GB12095@rei.lan>
Hi!
On 03/30/2017 05:35 PM, Cyril Hrubis wrote:
> Hi!
>> /* Deal with 32bit ABIs that have 64bit syscalls. */
>> # if LTP_USE_64_ABI
>> +#ifdef __TEST_H__
>> return ltp_syscall(__NR_fallocate, fd, mode, offset, len);
>> +#else
>> + return tst_syscall(__NR_fallocate, fd, mode, offset, len);
>> +#endif /* __TEST_H__ */
>> # else
>> +#ifdef __TEST_H__
>> return (long)ltp_syscall(__NR_fallocate, fd, mode,
>> __LONG_LONG_PAIR((off_t) (offset >> 32),
>> (off_t) offset),
>> __LONG_LONG_PAIR((off_t) (len >> 32),
>> (off_t) len));
>> +#else
>> + return (long)tst_syscall(__NR_fallocate, fd, mode,
>> + __LONG_LONG_PAIR((off_t) (offset >> 32),
>> + (off_t) offset),
>> + __LONG_LONG_PAIR((off_t) (len >> 32),
>> + (off_t) len));
>> +#endif /* __TEST_H__ */
>
> We can spare a bit of the duplication by definign the function name:
>
> ...
>
> #ifdef __TEST_H__
> # define TST_SYSCALL_WRAPPER ltp_syscall
> #else
> # define TST_SYSCALL_WRAPPER tst_syscall
> #endif
>
> ...
> return (long)TST_SYSCALL_WRAPPER(__NR_fallocate, fd, mode,
> __LONG_LONG_PAIR((off_t) (offset >> 32),
> (off_t) offset),
> __LONG_LONG_PAIR((off_t) (len >> 32),
> (off_t) len));
>
Oh, right, thanks a lot...
I will send a V2 soon.
Best Regards,
Guangwen Feng
next prev parent reply other threads:[~2017-03-30 9:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 18:15 [LTP] [PATCH v5 0/6] Added memfd_create() testsuite Jakub Racek
2017-03-23 18:15 ` [LTP] [PATCH v5 1/6] Added syscall numbers for memfd_create Jakub Racek
2017-03-23 18:15 ` [LTP] [PATCH v5 2/6] Added memfd_create() lapi flags Jakub Racek
2017-03-23 18:15 ` [LTP] [PATCH v5 3/6] Added fcntl() " Jakub Racek
2017-03-23 18:15 ` [LTP] [PATCH v5 4/6] move fallocate.h to lapi Jakub Racek
2017-03-23 18:15 ` [LTP] [PATCH v5 5/6] syscalls: added memfd_create dir and memfd_create/memfd_create01.c Jakub Racek
2017-03-24 15:26 ` Cyril Hrubis
2017-03-24 15:42 ` Jakub =?unknown-8bit?q?Ra=C4=8Dek?=
2017-03-29 8:42 ` Jan Stancek
2017-03-29 9:18 ` Cyril Hrubis
2017-03-29 9:32 ` [LTP] [PATCH] syscalls/memfd_create: Fix build fail when HAVE_FALLOCATE not defined Guangwen Feng
2017-03-30 9:35 ` Cyril Hrubis
2017-03-30 9:49 ` Guangwen Feng [this message]
2017-03-30 10:48 ` [LTP] [PATCH v2] syscalls/memfd_create: Fix build failure " Guangwen Feng
2017-03-30 13:34 ` Jan Stancek
2017-03-30 14:04 ` Cyril Hrubis
2017-03-23 18:15 ` [LTP] [PATCH v5 6/6] syscalls/memfd_create02.c: added new test Jakub Racek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58DCD4B1.5060705@cn.fujitsu.com \
--to=fenggw-fnst@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox