public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] hotplug/cpu_hotplug05.sh: Fix obsolete output of offline CPU
Date: Wed, 18 Jul 2018 15:10:38 +0800	[thread overview]
Message-ID: <5B4EE7EE.3090002@cn.fujitsu.com> (raw)
In-Reply-To: <1531898901-27234-1-git-send-email-yangx.jy@cn.fujitsu.com>

Hi,

Sorry, some typos in this patch, and i will resend it. :-(

Thanks,
Xiao Yang
On 2018/07/18 15:28, Xiao Yang wrote:
> With sysstat-11.7.1, running cpu_hotplug05.sh got the following error:
> ---------------------------------------------------------------------
> cpuhotplug05 1 TBROK: Field 3 is '%user', '0.00' expected
> ---------------------------------------------------------------------
>
> According to commit 970cae1 and 1f71a6f, sar/sadf didn't display offline
> CPU since sysstat-11.7.1.  It is reasonable for offline CPU to getting
> nothing.
>
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> ---
>  .../hotplug/cpu_hotplug/functional/cpuhotplug05.sh     | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
> index 59c8324..ab81684 100755
> --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
> +++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
> @@ -108,12 +108,18 @@ until [ $LOOP_COUNT -gt $HOTPLUG05_LOOPS ]; do
>  		tst_brkm TBROK "SAR output file is empty"
>  	fi
>  
> -	for i in $(seq 3 8); do
> -		field=$(get_field "$offline_status" "$i")
> -		if [ "$field" != "0.00" ]; then
> -			tst_brkm TBROK "Field $i is '$field', '0.00' expected"
> -		fi
> -	done
> +	cpu_field=$(get_field "$offline_status" "2")
> +	if [ "${cpu_field}" = "CPU" ]; then
> +		# Since sysstat-11.7.1, sar/sadf didn't display offline CPU
> +		tst_resm TINFO "SAR didn't display offline CPU"
> +	else
> +		for i in $(seq 3 8); do
> +			field=$(get_field "$offline_status" "$i")
> +			if [ "$field" != "0.00" ]; then
> +				tst_brkm TBROK "Field $i is '$field', '0.00' expected"
> +			fi
> +		done
> +	fi
>  
>  	# Online the CPU
>  	if ! online_cpu ${CPU_TO_TEST}; then




  reply	other threads:[~2018-07-18  7:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-18  7:28 [LTP] [PATCH] hotplug/cpu_hotplug05.sh: Fix obsolete output of offline CPU Xiao Yang
2018-07-18  7:10 ` Xiao Yang [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-07-18  7:33 Xiao Yang
2018-09-13  7:41 ` Xiao Yang
2018-10-02 11:32 ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5B4EE7EE.3090002@cn.fujitsu.com \
    --to=yangx.jy@cn.fujitsu.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox