From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/fsetxattr02.c: Fix the failure of opening device files
Date: Fri, 10 Aug 2018 08:13:57 +0800 [thread overview]
Message-ID: <5B6CD8C5.1040709@cn.fujitsu.com> (raw)
In-Reply-To: <20180809145723.5e6s3okx6rci2qdj@mobile.celeiro.br>
On 2018/08/09 22:57, Rafael David Tinoco wrote:
>> --- a/testcases/kernel/syscalls/fsetxattr/fsetxattr02.c
>> +++ b/testcases/kernel/syscalls/fsetxattr/fsetxattr02.c
>> @@ -52,11 +52,13 @@
>> #define FILENAME "fsetxattr02testfile"
>> #define DIRNAME "fsetxattr02testdir"
>> #define SYMLINK "fsetxattr02symlink"
>> -#define FIFO "fsetxattr02fifo"
>> -#define CHR "fsetxattr02chr"
>> -#define BLK "fsetxattr02blk"
>> +#define FIFO "/dev/fsetxattr02fifo"
>> +#define CHR "/dev/fsetxattr02chr"
>> +#define BLK "/dev/fsetxattr02blk"
> Thanks for catching this!! Minor issue: This will break OFFSET logic for
> tst_res() messages. They are skipping 11 chars because all files started
> with "fsetxattr02".
Hi Rafael,
Sorry for this rough fix, and i will send v2 patch as you suggested.
Thanks,
Xiao Yang
> -Rafael
>
>
>
prev parent reply other threads:[~2018-08-10 0:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 16:01 [LTP] [PATCH] syscalls/fsetxattr02.c: Fix the failure of opening device files Xiao Yang
2018-08-09 14:57 ` Rafael David Tinoco
2018-08-09 6:26 ` [LTP] [PATCH v2] " Xiao Yang
2018-08-10 12:50 ` Cyril Hrubis
2018-08-10 0:13 ` Xiao Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B6CD8C5.1040709@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox