[LTP] [PATCH 2/2] lib/tst_test.c: Restrict that tst_brk() only works with TBROK/TCONF

Xiao Yang
2018-12-12T07:14:51Z

On 2018/12/11 23:17, Cyril Hrubis wrote:
> Hi!
>> You are right, and i will send a v3 patch as you suggested.
> Are you going to send v3?
>
> I think that we really should increase counters on tst_brk(), that was
> an oversight when I designed the library.
>
> However summing up TBROK and TFAIL under results->failed does not look
> right to me.
Hi Cyril,

Yes, I am going to send v3.
I will pass TBROK to results->broken and TFAIL to results->failed in my
v3 patch.
> Also I'm not sure if we want to convert TFAIL to TWARN inside of test
> cleanup. And even if we wanted that change it should most likely go in
> in a separate patch.
Why do we need to convert TBROK to TWARN in test cleanup? Your fix
patch(commit 6440c5d)
has avoided the Infinite loop in test cleanup, so can we just keep the
actual result by removing
the existed conversion?

Best Regards,
Xiao Yang