From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] controllers/cpuset: cpuset.cpus file doesn't exist which triggers TFAIL
Date: Tue, 29 Jan 2019 19:07:01 +0800 [thread overview]
Message-ID: <5C5033D5.10705@cn.fujitsu.com> (raw)
In-Reply-To: <1548756794-121129-1-git-send-email-kerneljasonxing@linux.alibaba.com>
On 2019/01/29 18:13, Jason Xing wrote:
> When doing cpuset_hotplug test, it will mount cpuset filesystem on
> /dev/cpuset and try to 'cat' cpuset.cpus file. But the cpuset.cpus
> doesn't exist because the cgroup system generates cpus without 'cpuset'
> prefix instead. The result is undoubtly TFAIL.
>
> The old ltp test uses "mount -t cpuset cpuset "$CPUSET"" which will
> mount with 'noprefix' options in the kernel(see kernel/cgroup/cpuset.c).
> The reason is that it wants the backwards compatibility for the old
> cpuset file system. Therefore, using "mount -t cgroup -o" method
> surely fixes this issue once for all.
Hi Jason,
It looks good to me. :-)
Best Regards,
Xiao Yang
> Signed-off-by: Jason Xing<kerneljasonxing@linux.alibaba.com>
> ---
> testcases/kernel/controllers/cpuset/cpuset_funcs.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
> index cc31729..935a41e 100755
> --- a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
> +++ b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
> @@ -128,7 +128,7 @@ setup()
>
> mkdir -p "$CPUSET_TMP"
> mkdir "$CPUSET"
> - mount -t cpuset cpuset "$CPUSET" 2> /dev/null
> + mount -t cgroup -o cpuset cpuset "$CPUSET" 2> /dev/null
> if [ $? -ne 0 ]; then
> cleanup
> tst_brkm TFAIL "Could not mount cgroup filesystem with"\
next prev parent reply other threads:[~2019-01-29 11:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 10:13 [LTP] [PATCH] controllers/cpuset: cpuset.cpus file doesn't exist which triggers TFAIL Jason Xing
2019-01-29 11:07 ` Xiao Yang [this message]
2019-01-30 7:54 ` Jason Xing
2019-01-30 9:35 ` Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C5033D5.10705@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox