From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Yang Date: Tue, 29 Jan 2019 19:07:01 +0800 Subject: [LTP] [PATCH] controllers/cpuset: cpuset.cpus file doesn't exist which triggers TFAIL In-Reply-To: <1548756794-121129-1-git-send-email-kerneljasonxing@linux.alibaba.com> References: <1548756794-121129-1-git-send-email-kerneljasonxing@linux.alibaba.com> Message-ID: <5C5033D5.10705@cn.fujitsu.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it On 2019/01/29 18:13, Jason Xing wrote: > When doing cpuset_hotplug test, it will mount cpuset filesystem on > /dev/cpuset and try to 'cat' cpuset.cpus file. But the cpuset.cpus > doesn't exist because the cgroup system generates cpus without 'cpuset' > prefix instead. The result is undoubtly TFAIL. > > The old ltp test uses "mount -t cpuset cpuset "$CPUSET"" which will > mount with 'noprefix' options in the kernel(see kernel/cgroup/cpuset.c). > The reason is that it wants the backwards compatibility for the old > cpuset file system. Therefore, using "mount -t cgroup -o" method > surely fixes this issue once for all. Hi Jason, It looks good to me. :-) Best Regards, Xiao Yang > Signed-off-by: Jason Xing > --- > testcases/kernel/controllers/cpuset/cpuset_funcs.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh > index cc31729..935a41e 100755 > --- a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh > +++ b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh > @@ -128,7 +128,7 @@ setup() > > mkdir -p "$CPUSET_TMP" > mkdir "$CPUSET" > - mount -t cpuset cpuset "$CPUSET" 2> /dev/null > + mount -t cgroup -o cpuset cpuset "$CPUSET" 2> /dev/null > if [ $? -ne 0 ]; then > cleanup > tst_brkm TFAIL "Could not mount cgroup filesystem with"\