* [LTP] [PATCH] controllers/cpuset: cpuset.cpus file doesn't exist which triggers TFAIL
@ 2019-01-29 10:13 Jason Xing
2019-01-29 11:07 ` Xiao Yang
0 siblings, 1 reply; 4+ messages in thread
From: Jason Xing @ 2019-01-29 10:13 UTC (permalink / raw)
To: ltp
When doing cpuset_hotplug test, it will mount cpuset filesystem on
/dev/cpuset and try to 'cat' cpuset.cpus file. But the cpuset.cpus
doesn't exist because the cgroup system generates cpus without 'cpuset'
prefix instead. The result is undoubtly TFAIL.
The old ltp test uses "mount -t cpuset cpuset "$CPUSET"" which will
mount with 'noprefix' options in the kernel(see kernel/cgroup/cpuset.c).
The reason is that it wants the backwards compatibility for the old
cpuset file system. Therefore, using "mount -t cgroup -o" method
surely fixes this issue once for all.
Signed-off-by: Jason Xing <kerneljasonxing@linux.alibaba.com>
---
testcases/kernel/controllers/cpuset/cpuset_funcs.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
index cc31729..935a41e 100755
--- a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
+++ b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
@@ -128,7 +128,7 @@ setup()
mkdir -p "$CPUSET_TMP"
mkdir "$CPUSET"
- mount -t cpuset cpuset "$CPUSET" 2> /dev/null
+ mount -t cgroup -o cpuset cpuset "$CPUSET" 2> /dev/null
if [ $? -ne 0 ]; then
cleanup
tst_brkm TFAIL "Could not mount cgroup filesystem with"\
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [LTP] [PATCH] controllers/cpuset: cpuset.cpus file doesn't exist which triggers TFAIL
2019-01-29 10:13 [LTP] [PATCH] controllers/cpuset: cpuset.cpus file doesn't exist which triggers TFAIL Jason Xing
@ 2019-01-29 11:07 ` Xiao Yang
2019-01-30 7:54 ` Jason Xing
0 siblings, 1 reply; 4+ messages in thread
From: Xiao Yang @ 2019-01-29 11:07 UTC (permalink / raw)
To: ltp
On 2019/01/29 18:13, Jason Xing wrote:
> When doing cpuset_hotplug test, it will mount cpuset filesystem on
> /dev/cpuset and try to 'cat' cpuset.cpus file. But the cpuset.cpus
> doesn't exist because the cgroup system generates cpus without 'cpuset'
> prefix instead. The result is undoubtly TFAIL.
>
> The old ltp test uses "mount -t cpuset cpuset "$CPUSET"" which will
> mount with 'noprefix' options in the kernel(see kernel/cgroup/cpuset.c).
> The reason is that it wants the backwards compatibility for the old
> cpuset file system. Therefore, using "mount -t cgroup -o" method
> surely fixes this issue once for all.
Hi Jason,
It looks good to me. :-)
Best Regards,
Xiao Yang
> Signed-off-by: Jason Xing<kerneljasonxing@linux.alibaba.com>
> ---
> testcases/kernel/controllers/cpuset/cpuset_funcs.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
> index cc31729..935a41e 100755
> --- a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
> +++ b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
> @@ -128,7 +128,7 @@ setup()
>
> mkdir -p "$CPUSET_TMP"
> mkdir "$CPUSET"
> - mount -t cpuset cpuset "$CPUSET" 2> /dev/null
> + mount -t cgroup -o cpuset cpuset "$CPUSET" 2> /dev/null
> if [ $? -ne 0 ]; then
> cleanup
> tst_brkm TFAIL "Could not mount cgroup filesystem with"\
^ permalink raw reply [flat|nested] 4+ messages in thread
* [LTP] [PATCH] controllers/cpuset: cpuset.cpus file doesn't exist which triggers TFAIL
2019-01-29 11:07 ` Xiao Yang
@ 2019-01-30 7:54 ` Jason Xing
2019-01-30 9:35 ` Xiao Yang
0 siblings, 1 reply; 4+ messages in thread
From: Jason Xing @ 2019-01-30 7:54 UTC (permalink / raw)
To: ltp
On 2019/1/29 下午7:07, Xiao Yang wrote:
> On 2019/01/29 18:13, Jason Xing wrote:
>> When doing cpuset_hotplug test, it will mount cpuset filesystem on
>> /dev/cpuset and try to 'cat' cpuset.cpus file. But the cpuset.cpus
>> doesn't exist because the cgroup system generates cpus without 'cpuset'
>> prefix instead. The result is undoubtly TFAIL.
>>
>> The old ltp test uses "mount -t cpuset cpuset "$CPUSET"" which will
>> mount with 'noprefix' options in the kernel(see kernel/cgroup/cpuset.c).
>> The reason is that it wants the backwards compatibility for the old
>> cpuset file system. Therefore, using "mount -t cgroup -o" method
>> surely fixes this issue once for all.
> Hi Jason,
>
> It looks good to me. :-)
>
> Best Regards,
> Xiao Yang
Hi Yang,
Thanks for your review.
But it seems that the maintainers miss this patch, it's not a
complicated one, just one line changed. So I decided to reply to you all.
>> Signed-off-by: Jason Xing<kerneljasonxing@linux.alibaba.com>
>> ---
>> testcases/kernel/controllers/cpuset/cpuset_funcs.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
>> b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
>> index cc31729..935a41e 100755
>> --- a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
>> +++ b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
>> @@ -128,7 +128,7 @@ setup()
>>
>> mkdir -p "$CPUSET_TMP"
>> mkdir "$CPUSET"
>> - mount -t cpuset cpuset "$CPUSET" 2> /dev/null
>> + mount -t cgroup -o cpuset cpuset "$CPUSET" 2> /dev/null
>> if [ $? -ne 0 ]; then
>> cleanup
>> tst_brkm TFAIL "Could not mount cgroup filesystem with"\
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [LTP] [PATCH] controllers/cpuset: cpuset.cpus file doesn't exist which triggers TFAIL
2019-01-30 7:54 ` Jason Xing
@ 2019-01-30 9:35 ` Xiao Yang
0 siblings, 0 replies; 4+ messages in thread
From: Xiao Yang @ 2019-01-30 9:35 UTC (permalink / raw)
To: ltp
On 2019/01/30 15:54, Jason Xing wrote:
>
> On 2019/1/29 下午7:07, Xiao Yang wrote:
>> On 2019/01/29 18:13, Jason Xing wrote:
>>> When doing cpuset_hotplug test, it will mount cpuset filesystem on
>>> /dev/cpuset and try to 'cat' cpuset.cpus file. But the cpuset.cpus
>>> doesn't exist because the cgroup system generates cpus without 'cpuset'
>>> prefix instead. The result is undoubtly TFAIL.
>>>
>>> The old ltp test uses "mount -t cpuset cpuset "$CPUSET"" which will
>>> mount with 'noprefix' options in the kernel(see
>>> kernel/cgroup/cpuset.c).
>>> The reason is that it wants the backwards compatibility for the old
>>> cpuset file system. Therefore, using "mount -t cgroup -o" method
>>> surely fixes this issue once for all.
>> Hi Jason,
>>
>> It looks good to me. :-)
>>
>> Best Regards,
>> Xiao Yang
>
> Hi Yang,
>
> Thanks for your review.
>
> But it seems that the maintainers miss this patch, it's not a
> complicated one, just one line changed. So I decided to reply to you all.
Hi Jason,
Pushed, thanks for your work.
Best Regards,
Xiao Yang
>
>>> Signed-off-by: Jason Xing<kerneljasonxing@linux.alibaba.com>
>>> ---
>>> testcases/kernel/controllers/cpuset/cpuset_funcs.sh | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
>>> b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
>>> index cc31729..935a41e 100755
>>> --- a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
>>> +++ b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
>>> @@ -128,7 +128,7 @@ setup()
>>>
>>> mkdir -p "$CPUSET_TMP"
>>> mkdir "$CPUSET"
>>> - mount -t cpuset cpuset "$CPUSET" 2> /dev/null
>>> + mount -t cgroup -o cpuset cpuset "$CPUSET" 2> /dev/null
>>> if [ $? -ne 0 ]; then
>>> cleanup
>>> tst_brkm TFAIL "Could not mount cgroup filesystem with"\
>>
>>
>
>
> .
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-30 9:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-29 10:13 [LTP] [PATCH] controllers/cpuset: cpuset.cpus file doesn't exist which triggers TFAIL Jason Xing
2019-01-29 11:07 ` Xiao Yang
2019-01-30 7:54 ` Jason Xing
2019-01-30 9:35 ` Xiao Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox