From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] Remove break after return
Date: Thu, 4 Apr 2019 09:29:33 +0800 [thread overview]
Message-ID: <5CA55DFD.4010701@cn.fujitsu.com> (raw)
In-Reply-To: <20190403120655.GA20621@dell5510>
On 2019/04/03 20:06, Petr Vorel wrote:
>>> Can we also remove break after calling tst_brk()?
>> > AFAIK that would generate warnings, since compiler cannot deduce on it's
>> > own that the call will not return.
> Agree.
>
Hi,
Thanks for your explanation.
Other than the question, it looks good to me.
Reviewed-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
Best Regards,
Xiao Yang
next prev parent reply other threads:[~2019-04-04 1:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 10:50 [LTP] [PATCH 1/1] Remove break after return Petr Vorel
2019-03-28 10:59 ` Enji Cooper
2019-03-29 3:04 ` Xiao Yang
2019-04-03 12:02 ` Cyril Hrubis
2019-04-03 12:06 ` Petr Vorel
2019-04-04 1:29 ` Xiao Yang [this message]
2019-04-05 6:48 ` Petr Vorel
2019-04-05 3:22 ` Xiao Yang
2019-04-05 6:56 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5CA55DFD.4010701@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox