From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] Remove break after return
Date: Fri, 5 Apr 2019 11:22:31 +0800 [thread overview]
Message-ID: <5CA6C9F7.1060907@cn.fujitsu.com> (raw)
In-Reply-To: <20190328105006.17337-1-pvorel@suse.cz>
On 2019/03/28 18:50, Petr Vorel wrote:
> Reported-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> testcases/kernel/syscalls/select/select_var.h | 1 -
> testcases/kernel/syscalls/sigpending/sigpending02.c | 3 ---
> 2 files changed, 4 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/select/select_var.h b/testcases/kernel/syscalls/select/select_var.h
> index b19a1d1bf..29ebbc5ee 100644
> --- a/testcases/kernel/syscalls/select/select_var.h
> +++ b/testcases/kernel/syscalls/select/select_var.h
> @@ -20,7 +20,6 @@ static int do_select(int nfds, fd_set *readfds, fd_set *writefds, fd_set *except
> switch (tst_variant) {
> case 0:
> return select(nfds, readfds, writefds, exceptfds, timeout);
> - break;
> case 1: {
> #ifdef __LP64__
> return tst_syscall(__NR_select, nfds, readfds, writefds, exceptfds, timeout);
> diff --git a/testcases/kernel/syscalls/sigpending/sigpending02.c b/testcases/kernel/syscalls/sigpending/sigpending02.c
> index ce0d2ff79..d75807d77 100644
> --- a/testcases/kernel/syscalls/sigpending/sigpending02.c
> +++ b/testcases/kernel/syscalls/sigpending/sigpending02.c
> @@ -37,13 +37,10 @@ static int tested_sigpending(sigset_t *sigset)
> switch (tst_variant) {
> case 0:
> return sigpending(sigset);
> - break;
Hi Petr,
I have added libc sigpending() detection by the following patch:
http://lists.linux.it/pipermail/ltp/2019-April/011590.html
Perhaps, we should avoid potential compiler warnings by keeping the
break here.
Best Regards,
Xiao Yang
> case 1:
> return tst_syscall(__NR_sigpending, sigset);
> - break;
> case 2:
> return tst_syscall(__NR_rt_sigpending, sigset, SIGSETSIZE);
> - break;
> }
> return -1;
> }
next prev parent reply other threads:[~2019-04-05 3:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 10:50 [LTP] [PATCH 1/1] Remove break after return Petr Vorel
2019-03-28 10:59 ` Enji Cooper
2019-03-29 3:04 ` Xiao Yang
2019-04-03 12:02 ` Cyril Hrubis
2019-04-03 12:06 ` Petr Vorel
2019-04-04 1:29 ` Xiao Yang
2019-04-05 6:48 ` Petr Vorel
2019-04-05 3:22 ` Xiao Yang [this message]
2019-04-05 6:56 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5CA6C9F7.1060907@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox