From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 2/2] syscalls/pidfd_open*.c: Drop .min_kver flag
Date: Wed, 13 May 2020 14:31:43 +0800 [thread overview]
Message-ID: <5EBB944F.5010303@cn.fujitsu.com> (raw)
In-Reply-To: <20200513061343.mjhmciatmx4sw2ub@vireshk-i7>
? 2020/5/13 14:13, Viresh Kumar ??:
> On 13-05-20, 14:03, Xiao Yang wrote:
>> Could you tell which issue happen? Thanks a lot.
>> The other two don't need the extra check because the implementation of
>> pidfd_open() can do it well. For 3rd test, I want to check the support of
>> pidfs_open() before doing fork().
>
> What I meant was that the solution needs to be consistent across
Hi Viresh,
Current change can do correct check for pidfd_open[1-3] so don't need to
add redundant check.
> tests. For example, with the current change the run() function will
> run for all tests in pidfd_open02.c and print the message that syscall
> isn't supported, while it would be better to run it only once in setup
> and get done with it. i.e. 1 message instead of 3 similar ones.
>
Are you sure?
Triggering first tst_brk(TCONF, ...) will break the whole test instead
of a subtest.
Thanks,
Xiao Yang
next prev parent reply other threads:[~2020-05-13 6:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 1:26 [LTP] [PATCH v2 1/2] syscalls/pidfd_open01.c: Add check for close-on-exec flag Xiao Yang
2020-05-13 1:26 ` [LTP] [PATCH v2 2/2] syscalls/pidfd_open*.c: Drop .min_kver flag Xiao Yang
2020-05-13 5:55 ` Viresh Kumar
2020-05-13 6:03 ` Xiao Yang
2020-05-13 6:13 ` Viresh Kumar
2020-05-13 6:31 ` Xiao Yang [this message]
2020-05-13 6:39 ` Viresh Kumar
2020-05-13 2:28 ` [LTP] [PATCH v2 1/2] syscalls/pidfd_open01.c: Add check for close-on-exec flag Xiao Yang
2020-05-13 9:20 ` Petr Vorel
2020-05-13 10:21 ` Xiao Yang
2020-05-13 10:30 ` Petr Vorel
2020-05-14 7:37 ` Petr Vorel
2020-05-14 9:43 ` Xiao Yang
2020-05-14 14:14 ` Petr Vorel
2020-05-14 14:27 ` Xiao Yang
2020-05-13 12:34 ` Cyril Hrubis
2020-05-13 13:12 ` Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5EBB944F.5010303@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox