public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
* [LTP] [PATCH v1 1/2] tpci: remove useless ENABLE_BRIDGES
@ 2020-05-13  7:06 Yang Xu
  2020-05-13  7:06 ` [LTP] [PATCH v1 2/2] tpci: Remove deprecated CONFIG_HOTPLUG Yang Xu
  2020-05-18  3:26 ` [LTP] [PATCH v1 1/2] tpci: remove useless ENABLE_BRIDGES Xiao Yang
  0 siblings, 2 replies; 3+ messages in thread
From: Yang Xu @ 2020-05-13  7:06 UTC (permalink / raw)
  To: ltp

Since the previous commit, we have removed test_enable_bridges() because
pci_enable_bridges() was removed in 3.12 (928bea964827). But it forgot
to delete it in tpci.h. So remove it.

Fixes: 3dd286b ("ltp_tpci.c: Update legacy code")
Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
 testcases/kernel/device-drivers/pci/tpci_kernel/tpci.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/testcases/kernel/device-drivers/pci/tpci_kernel/tpci.h b/testcases/kernel/device-drivers/pci/tpci_kernel/tpci.h
index f65c6fc22..f7defb29f 100644
--- a/testcases/kernel/device-drivers/pci/tpci_kernel/tpci.h
+++ b/testcases/kernel/device-drivers/pci/tpci_kernel/tpci.h
@@ -30,7 +30,6 @@ enum PCI_TCASES {
 	FIND_SUBSYS,
 	BUS_SCAN,
 	SLOT_SCAN,
-	ENABLE_BRIDGES,
 	BUS_ADD_DEVICES,
 	MATCH_DEVICE,
 	REG_DRIVER,
-- 
2.23.0




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [LTP] [PATCH v1 2/2] tpci: Remove deprecated CONFIG_HOTPLUG
  2020-05-13  7:06 [LTP] [PATCH v1 1/2] tpci: remove useless ENABLE_BRIDGES Yang Xu
@ 2020-05-13  7:06 ` Yang Xu
  2020-05-18  3:26 ` [LTP] [PATCH v1 1/2] tpci: remove useless ENABLE_BRIDGES Xiao Yang
  1 sibling, 0 replies; 3+ messages in thread
From: Yang Xu @ 2020-05-13  7:06 UTC (permalink / raw)
  To: ltp

Since kernel commit 40b313608ad4 ("Finally eradicate CONFIG_HOTPLUG"),
it always supports hotplug. It is about 7 years old and many distributions
don't have this config, so we can remove it safely.

Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
 README.kernel_config                                       | 1 -
 testcases/kernel/device-drivers/pci/tpci_kernel/ltp_tpci.c | 5 -----
 2 files changed, 6 deletions(-)

diff --git a/README.kernel_config b/README.kernel_config
index ffb2dec95..547dd4f33 100644
--- a/README.kernel_config
+++ b/README.kernel_config
@@ -131,7 +131,6 @@ CONFIG_KEXEC_JUMP=y
 ---------------------------------
 Enabling HOTPLUG for your Kernels
 ---------------------------------
-CONFIG_HOTPLUG=y
 CONFIG_HOTPLUG_CPU=y
 CONFIG_ARCH_ENABLE_MEMORY_HOTPLUG=y
 CONFIG_ACPI_HOTPLUG_CPU=y
diff --git a/testcases/kernel/device-drivers/pci/tpci_kernel/ltp_tpci.c b/testcases/kernel/device-drivers/pci/tpci_kernel/ltp_tpci.c
index a57953db6..e29821dda 100644
--- a/testcases/kernel/device-drivers/pci/tpci_kernel/ltp_tpci.c
+++ b/testcases/kernel/device-drivers/pci/tpci_kernel/ltp_tpci.c
@@ -290,7 +290,6 @@ static int test_find_subsys(void)
  */
 static int test_scan_bus(void)
 {
-#ifdef CONFIG_HOTPLUG
 	int num;
 	struct pci_bus *bus = ltp_pci.bus;
 
@@ -307,10 +306,6 @@ static int test_scan_bus(void)
 	}
 	prk_info("success scan bus");
 	return TPASS;
-#else
-	prk_info("pci_rescan_bus() is not supported");
-	return TSKIP;
-#endif
 }
 
 /*
-- 
2.23.0




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [LTP] [PATCH v1 1/2] tpci: remove useless ENABLE_BRIDGES
  2020-05-13  7:06 [LTP] [PATCH v1 1/2] tpci: remove useless ENABLE_BRIDGES Yang Xu
  2020-05-13  7:06 ` [LTP] [PATCH v1 2/2] tpci: Remove deprecated CONFIG_HOTPLUG Yang Xu
@ 2020-05-18  3:26 ` Xiao Yang
  1 sibling, 0 replies; 3+ messages in thread
From: Xiao Yang @ 2020-05-18  3:26 UTC (permalink / raw)
  To: ltp

Hi,

Thanks for your work, pushed.

Best Regards,
Xiao Yang
On 2020/5/13 15:06, Yang Xu wrote:
> Since the previous commit, we have removed test_enable_bridges() because
> pci_enable_bridges() was removed in 3.12 (928bea964827). But it forgot
> to delete it in tpci.h. So remove it.
>
> Fixes: 3dd286b ("ltp_tpci.c: Update legacy code")
> Signed-off-by: Yang Xu<xuyang2018.jy@cn.fujitsu.com>
> ---
>   testcases/kernel/device-drivers/pci/tpci_kernel/tpci.h | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/testcases/kernel/device-drivers/pci/tpci_kernel/tpci.h b/testcases/kernel/device-drivers/pci/tpci_kernel/tpci.h
> index f65c6fc22..f7defb29f 100644
> --- a/testcases/kernel/device-drivers/pci/tpci_kernel/tpci.h
> +++ b/testcases/kernel/device-drivers/pci/tpci_kernel/tpci.h
> @@ -30,7 +30,6 @@ enum PCI_TCASES {
>   	FIND_SUBSYS,
>   	BUS_SCAN,
>   	SLOT_SCAN,
> -	ENABLE_BRIDGES,
>   	BUS_ADD_DEVICES,
>   	MATCH_DEVICE,
>   	REG_DRIVER,




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-18  3:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-13  7:06 [LTP] [PATCH v1 1/2] tpci: remove useless ENABLE_BRIDGES Yang Xu
2020-05-13  7:06 ` [LTP] [PATCH v1 2/2] tpci: Remove deprecated CONFIG_HOTPLUG Yang Xu
2020-05-18  3:26 ` [LTP] [PATCH v1 1/2] tpci: remove useless ENABLE_BRIDGES Xiao Yang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox