From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] tirpc: Pass all extra client options to client program
Date: Wed, 20 May 2020 22:17:01 +0800 [thread overview]
Message-ID: <5EC53BDD.9050400@cn.fujitsu.com> (raw)
In-Reply-To: <20200520132501.GA22418@dell5510>
ON 2020/5/20 21:25, Petr Vorel wrote:
> Hi Yang,
>
>> New rpc_test.sh only passes the first extra client option to
>> client program if extra client options are two or more.
>> For example, only "1" is passed into tirpc_rpc_broadcast_exp:
>> -------------------------------------------
>> ./runltp -f net.tirpc_tests -s tirpc_rpc_broadcast_exp
>> ...
>> tag=tirpc_rpc_broadcast_exp stime=1589957933
>> cmdline="rpc_test.sh -s tirpc_svc_1 -c tirpc_rpc_broadcast_exp -e "1 2""
>> ...
>> rpc_test 1 TFAIL: tirpc_rpc_broadcast_exp 10.0.0.2 536875000 1 failed unexpectedly
>> -------------------------------------------
>> For extra client options, use comma as a delimiter in net.tirpc_tests
>> and replace it with white space in rpc_test.sh
>
>> Fixes: 3190368d2df8 ("rpc/rpc_test.sh: Rewrite into new shell API")
>> Signed-off-by: Xiao Yang<yangx.jy@cn.fujitsu.com>
>
> Thanks a lot for a fix!
>
> I replaced bashism in OPTARG handling with sed (otherwise it'd fail on dash) and
> merged.
Hi Petr,
Thanks for your change.
I will avoid bashism next time.
Best Regards,
Xiao Yang
>
> Kind regards,
> Petr
>
>
> .
>
prev parent reply other threads:[~2020-05-20 14:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 7:26 [LTP] [PATCH] tirpc: Pass all extra client options to client program Xiao Yang
2020-05-20 13:25 ` Petr Vorel
2020-05-20 14:17 ` Xiao Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5EC53BDD.9050400@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox