From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] lib/tst_test.c: Take account of tst_brk(TCONF/TFAIL) in summary output
Date: Tue, 26 May 2020 21:43:20 +0800 [thread overview]
Message-ID: <5ECD1CF8.5010607@cn.fujitsu.com> (raw)
In-Reply-To: <20200522014007.3108-1-yangx.jy@cn.fujitsu.com>
Hi,
I want to push it tomorrow if nobody has any objection.
Thanks,
Xiao Yang
On 2020/5/22 9:40, Xiao Yang wrote:
> Current summary output doesn't take account of tst_brk(TCONF/TFAIL),
> for example:
> -----------------------------------------------------
> [root@Fedora-30 pidfd_send_signal]# ./pidfd_send_signal01
> tst_test.c:1246: INFO: Timeout per run is 0h 05m 00s
> ../../../../include/lapi/pidfd_send_signal.h:16: CONF: syscall(424) __NR_pidfd_send_signal not supported
>
> Summary:
> passed 0
> failed 0
> skipped 0
> warnings 0
> ----------------------------------------------------
>
> 1) Add update_result() in tst_vbrk_() to fix the issue.
> 2) Remove redundant update_result() in run_tcases_per_fs() after the fix.
>
> Signed-off-by: Xiao Yang<yangx.jy@cn.fujitsu.com>
> ---
> lib/tst_test.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/lib/tst_test.c b/lib/tst_test.c
> index 0e58060e0..e93c88ba5 100644
> --- a/lib/tst_test.c
> +++ b/lib/tst_test.c
> @@ -316,6 +316,7 @@ void tst_vbrk_(const char *file, const int lineno, int ttype,
> const char *fmt, va_list va)
> {
> print_result(file, lineno, ttype, fmt, va);
> + update_results(TTYPE_RESULT(ttype));
>
> /*
> * The getpid implementation in some C library versions may cause cloned
> @@ -1316,10 +1317,8 @@ static int run_tcases_per_fs(void)
> mntpoint_mounted = 0;
> }
>
> - if (ret == TCONF) {
> - update_results(ret);
> + if (ret == TCONF)
> continue;
> - }
>
> if (ret == 0)
> continue;
next prev parent reply other threads:[~2020-05-26 13:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 5:43 [LTP] [PATCH] lib/tst_test.c: Take account of tst_brk(TCONF)/tst_brk(TFAIL) in summary output Xiao Yang
2020-05-19 14:34 ` Cyril Hrubis
2020-05-20 2:02 ` Xiao Yang
2020-05-22 1:40 ` [LTP] [PATCH v2] lib/tst_test.c: Take account of tst_brk(TCONF/TFAIL) " Xiao Yang
2020-05-26 13:43 ` Xiao Yang [this message]
2020-05-27 7:08 ` Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ECD1CF8.5010607@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox