From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] LIB: Use INTERNAL_LIB for ltp lib
Date: Wed, 10 Jun 2020 16:47:13 +0800 [thread overview]
Message-ID: <5EE09E11.102@cn.fujitsu.com> (raw)
In-Reply-To: <20200610080529.GA19781@dell5510>
On 2020/6/10 16:05, Petr Vorel wrote:
> Hi Xu,
>
>> Hi Petr
>
>> Nothing blocks this simple patch, I guess we can directly push this
>> patch(don't forget jan's acked-by).
>
> I guess you missed librealtime.a in (testcases/realtime/lib/Makefile).
>
> Maybe removing libdir could be in separate commit, it looks to me as unrelated
> change.
Hi Petr, Xu
Agreed, This patch should focus on replacing LIB with INTERNAL_LIB.
My question about the issue is not important, we can just keep libdir
for now as you want because someone may add dynamic library linking in
future.
Thanks,
Xiao Yang
>
> And you haven't replied to my question:
> https://lists.linux.it/pipermail/ltp/2020-June/017495.html
>
> But newer mind :). Maybe it's just me, but "Also include Android_libpthread and
> android_librt." is not clear to me. I'd phrase it: "Also change Android_libpthread and
> android_librt" (because include is ambiguous, when we're trying not to
> install/include these statically linked libraries.
>
> BTW if you ack it, I can do this changes before merge.
>
> Kind regards,
> Petr
>
next prev parent reply other threads:[~2020-06-10 8:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <57a1c19e-d8e5-4389-8565-20e49f144657@G08CNEXMBPEKD05.g08.fujitsu.local>
2020-06-10 1:28 ` [LTP] [PATCH v2] LIB: Use INTERNAL_LIB for ltp lib Yang Xu
2020-06-10 8:05 ` Petr Vorel
2020-06-10 8:21 ` Yang Xu
2020-06-10 9:51 ` Petr Vorel
2020-06-10 8:47 ` Xiao Yang [this message]
2020-06-10 10:48 ` Petr Vorel
2020-06-02 7:37 Yang Xu
2020-06-08 10:10 ` Petr Vorel
2020-06-08 11:01 ` Yang Xu
2020-06-08 11:41 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5EE09E11.102@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox