[LTP] LTP release

Li Wang
2017-04-27T02:51:01Z

On Wed, Apr 26, 2017 at 8:59 PM, Jan Stancek <jstancek@redhat.com> wrote:
>
>
> ----- Original Message -----
>> Hi!
>> > > It's about a time we should prepare for another release, hence as
>> > > usuall, lets start with pointing out any patches that should be part of
>> > > it and I would like to start with pre-release testing at the end of this
>> > > week. Does that sound OK to everyone?
>> >
>> > ioctl06 always failed on aarch64(others PASS) with upstream
>> > kernel-4.11-rc[1-7]. Not sure if it is a bug or not, since i'm still
>> > on debugging way. Just report here to let you know this.
>
> I'm seeing it fail on ppc as well (64k pages), with older RHEL7 kernels:
>
>> Looks like the value is rounded to be multiple of 128, that may be just
>> intentional limitation, but we should better check with the kernel
>> source or ask kernel devs.
>
> block/ioctl.c:
> case BLKRASET:
> case BLKFRASET:
> if(!capable(CAP_SYS_ADMIN))
> return -EACCES;
> bdev->bd_bdi->ra_pages = (arg * 512) / PAGE_SIZE;
> return 0;
>

how about makes change as:

--- a/testcases/kernel/syscalls/ioctl/ioctl06.c
+++ b/testcases/kernel/syscalls/ioctl/ioctl06.c
@@ -31,12 +31,13 @@ static int fd;
static void verify_ioctl(void)
{
unsigned long ra, rab, rao;
+ unsigned long ra_shift = getpagesize() / 512;

SAFE_IOCTL(fd, BLKRAGET, &rao);

tst_res(TINFO, "BLKRAGET original value %lu", rao);

- for (ra = 0; ra <= 512; ra += 64) {
+ for (ra = 0; ra <= ra_shift * 8; ra += ra_shift) {
SAFE_IOCTL(fd, BLKRASET, ra);
SAFE_IOCTL(fd, BLKRAGET, &rab);

--
Regards,
Li Wang
Email: liwang@redhat.com