From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] Broken Fedora build
Date: Thu, 22 Oct 2020 13:18:53 +0800 [thread overview]
Message-ID: <5F91163D.9030307@cn.fujitsu.com> (raw)
In-Reply-To: <5F90F214.20102@cn.fujitsu.com>
On 2020/10/22 10:44, Yang Xu wrote:
> Hi Li,Petr
>> Petr Vorel<pvorel@suse.cz> wrote:
>>
>>> Fedora build is broken due missing<sys/timeb.h> [1].
>>> Quick fix would probably be to use Fedora 33 instead of Rawhide. [2]
>>> But we should port hugetlb.c and trace_sched.c (if used) to
>>> gettimeofday or
>>> clock_gettime. [3]
>>
>> +1
>> I prefer to go replace ftime() by gettimeofday() or clock_gettime()
>> way to solve this from root.
> +1
>
> I have seen the hugetlb.c and trace_sched.c code, they all use the
> time to generate a random value for ftok or sched_priority. So using
> gettimeofday() also looks ok.
Hi,
It is fine for me to replace ftime(), but I wonder if we can remove
fime() and srand()/srandom() directly? :-)
It seems unnecessary to set the seed for random number.
Best Regards,
Xiao Yang
>
> I will send a patch to use gettimeofday.
>
> Best Regards
> Yang Xu
>>
>
>
>
>
next prev parent reply other threads:[~2020-10-22 5:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 19:35 [LTP] Broken Fedora build Petr Vorel
2020-10-22 2:36 ` Li Wang
2020-10-22 2:44 ` Yang Xu
2020-10-22 5:18 ` Xiao Yang [this message]
2020-10-22 5:47 ` Li Wang
2020-10-22 6:22 ` Yang Xu
2020-10-22 6:27 ` Xiao Yang
2020-10-22 6:01 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5F91163D.9030307@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox