From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yang Xu Date: Wed, 6 Jan 2021 10:18:05 +0800 Subject: [LTP] [PATCH] syscalls/ioctl_loop05.c: skip test on overlay filesystem In-Reply-To: References: <20201215155650.6496-1-radoslav.kolev@suse.com> <5FD96C97.6020602@cn.fujitsu.com> <5FD9C58B.9020807@cn.fujitsu.com> Message-ID: <5FF51DDD.3080709@cn.fujitsu.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi Cyril > Hi! >> diff --git a/lib/tst_device.c b/lib/tst_device.c >> index c096b418b..de64fd908 100644 >> --- a/lib/tst_device.c >> +++ b/lib/tst_device.c >> @@ -534,6 +534,10 @@ void tst_find_backing_dev(const char *path, char *dev) >> if (stat(dev,&buf)< 0) >> tst_brkm(TWARN | TERRNO, NULL, "stat(%s) failed", dev); >> >> - if (S_ISBLK(buf.st_mode) != 1) >> - tst_brkm(TCONF, NULL, "dev(%s) isn't a block dev", dev); >> + if (S_ISBLK(buf.st_mode) != 1) { >> + if (tst_is_mounted(dev)) >> + tst_find_backing_dev(dev, dev); >> + else >> + tst_brkm(TCONF, NULL, "dev(%s) isn't a block >> dev", dev); >> + } >> } >> >> My test environment is that >> /dev/sda10 20G 623M 18G 4% /mnt/xfstests/test >> /mnt/xfstests/test 20G 623M 18G 4% /mnt/xfstests/test/ovl-mnt >> /dev/sda11 20G 46M 19G 1% /mnt/xfstests/scratch >> /mnt/xfstests/scratch 20G 46M 19G 1% /mnt/xfstests/scratch/ovl-mnt >> >> and my TMPDIR env is /mnt/xfstests/test/ovl-mnt. > > Does this code works for everyone or should we apply patch that disables > the test on overlay so that it's fixed for next release? I guess it is ok for everyone, but I want to listen some advise from Amir since he is an expert about overlay filesystem. Hi Amir Currently, Radoslav reported ltp tst_find_backing_dev api (we prase /proc/self/mountinfo and use " - " to delim string and get the bdev value after two fileds.) can not find really block dev when using overlay filesystem. It fails because this api doesn't consider user layer filesystem(like overlay). I think we should call tst_find_backing_dev_api again if this dev variable is not block dev and it is a mountpoint. I use the above environment and it is ok. Wha do you think about it? Best Regards Yang Xu >