public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: yangx.jy <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] build.sh: support compiler with path prefix
Date: Mon, 11 Jan 2021 09:39:39 +0800	[thread overview]
Message-ID: <5FFBAC5B.8060808@cn.fujitsu.com> (raw)
In-Reply-To: <20210111012338.5482-1-lizhijian@cn.fujitsu.com>

On 2021/1/11 9:23, Li Zhijian wrote:
> Previously, specify a compiler with path prefix will lead to a error
> like below:
> ltp$ ./build.sh -t cross -c /opt/gcc-4.9.3-64-gnu/bin/mips64el-linux-gcc
> ...
> It was created by ltp configure LTP_VERSION, which was
> generated by GNU Autoconf 2.69.  Invocation command line was
>
>    $ ./configure --with-open-posix-testsuite --with-realtime-testsuite --prefix=/home/lizj/ltp-install --host=/opt/gcc-4.9.3-64-gnu/bin/mips64el-linux CROSS_COMPILE=/opt/gcc-4.9.3-64-gnu/bin/mips64el-linux-
> ...
>   #define VERSION "LTP_VERSION"
>
> configure: exit 1
>
> Signed-off-by: Li Zhijian<lizhijian@cn.fujitsu.com>
> ---
>   build.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/build.sh b/build.sh
> index 452cc6f4c..a662c9cb4 100755
> --- a/build.sh
> +++ b/build.sh
> @@ -64,7 +64,7 @@ build_cross()
>   	fi
>
>   	echo "===== cross-compile ${host} ${1}-tree build into $PREFIX ====="
> -	build $1 $2 "--host=$host" CROSS_COMPILE="${host}-"
> +	build $1 $2 "--host=$(basename $host)" CROSS_COMPILE="${host}-"
Hi Petr,

CROSS_COMPILE seems unneeeded, right?
Other than that it looks good to me.
Reviewed-by: Xiao Yang <yangx.jy@cn.fujitsu.com>

Best Regards,
Xiao Yang
>   }
>
>   build()




  reply	other threads:[~2021-01-11  1:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-11  1:23 [LTP] [PATCH] build.sh: support compiler with path prefix Li Zhijian
2021-01-11  1:39 ` yangx.jy [this message]
2021-01-11  3:03   ` Li Zhijian
2021-01-11  8:22 ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5FFBAC5B.8060808@cn.fujitsu.com \
    --to=yangx.jy@cn.fujitsu.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox