public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Zhu Feiyu <zhufy.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] cpio_tests.sh: Fix failure with BusyBox cpio
Date: Wed, 20 Jan 2021 15:19:22 +0800	[thread overview]
Message-ID: <6007D97A.9010804@cn.fujitsu.com> (raw)
In-Reply-To: <X/RJhbNBfja6/Snr@pevik>

Hi Petr
> Hi Radoslav,
>
> ...
>>> +
>>> +if cpio 2>&1 | grep -q '\-o\sCreate (requires -H newc)'; then
> Thanks for your fix, merged with these changes:
>
> * grep for BusyBox because some older versions does not contain the
> hint, but actually require it.
>
> * move things to setup function due my following commit, which cannot be
> outside API functions (setup/test function):
> And check for -o (which is on BusyBox optional).
On my test environment, just executing cpio with no arguments will only 
output:
cpio: You must specify one of -oipt options.
Try `cpio --help' or `cpio --usage' for more information.

So the result of cpio01_sh is changed from PASS to CONF after commit 
5910bdb65c.
Is there any difference in the output from executing this command on 
your environment?

Best Regards
Feiyu Zhu
>
> Kind regards,
> Petr
>




  parent reply	other threads:[~2021-01-20  7:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-21 11:01 [LTP] [PATCH] cpio_tests.sh: Fix failure with BusyBox cpio Radoslav Kolev
2020-12-22 17:10 ` Petr Vorel
2021-01-05 11:12   ` Petr Vorel
2021-01-05 12:04     ` Radoslav Kolev
2021-01-20  7:19     ` Zhu Feiyu [this message]
2021-01-20  9:39       ` Petr Vorel
2021-01-20 11:00       ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6007D97A.9010804@cn.fujitsu.com \
    --to=zhufy.jy@cn.fujitsu.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox