Linux Test Project
 help / color / mirror / Atom feed
From: Zhu Feiyu <zhufy.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 5/5] syscalls/ipc: semctl07: Convert to new API and cleanup
Date: Thu, 28 Jan 2021 17:52:04 +0800	[thread overview]
Message-ID: <60128944.7080501@cn.fujitsu.com> (raw)
In-Reply-To: <YBFboS09Wgc9F7TF@yuki.lan>

Hi Cyril,

>
> This part is broken. We do issue the TPASS here even if one of the above
> statement issued TFAIL.
>
> So we either change the code to produce TPASS/TFAIL pair on each check
> e.g.
>
> 	if (status != arg.val) {
> 		tst_res(TFAIL, "semctl(GETVAL) returned %d expected %d",
> 		        arg.val, status);
> 	} else {
> 		tst_res(TPASS, "semctl(GETVAL) returned %d", arg.val);
> 	}
>
> Or we have to maintain flag that is set to non-zero on any failure and
> then we can, at the end of the test do:
>
> 	if (!flag)
> 		tst_res(TPASS, "everything is fine");
>

Thanks for your review, I have sent v2.

Best Regards
Feiyu Zhu



  reply	other threads:[~2021-01-28  9:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-06  7:27 [LTP] [PATCH 1/5] syscalls/ipc: semctl02: Convert to new API and cleanup Feiyu Zhu
2021-01-06  7:27 ` [LTP] [PATCH 2/5] syscalls/ipc: semctl03: " Feiyu Zhu
2021-01-26 14:17   ` Cyril Hrubis
2021-01-06  7:27 ` [LTP] [PATCH 3/5] syscalls/ipc: semctl04: " Feiyu Zhu
2021-01-26 15:43   ` Cyril Hrubis
2021-01-06  7:27 ` [LTP] [PATCH 4/5] syscalls/ipc: semctl05: " Feiyu Zhu
2021-01-26 16:18   ` Cyril Hrubis
2021-01-06  7:27 ` [LTP] [PATCH 5/5] syscalls/ipc: semctl07: " Feiyu Zhu
2021-01-27 12:25   ` Cyril Hrubis
2021-01-28  9:52     ` Zhu Feiyu [this message]
2021-01-26 13:11 ` [LTP] [PATCH 1/5] syscalls/ipc: semctl02: " Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60128944.7080501@cn.fujitsu.com \
    --to=zhufy.jy@cn.fujitsu.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox